Skip to content

fix: show report click feedback and log path - #10

Merged
GabrielBBaldez merged 1 commit into
stacktale:mainfrom
11suixing11:fix/report-click-feedback-log-path
Jul 28, 2026
Merged

fix: show report click feedback and log path#10
GabrielBBaldez merged 1 commit into
stacktale:mainfrom
11suixing11:fix/report-click-feedback-log-path

Conversation

@11suixing11

Copy link
Copy Markdown
Contributor

Summary

  • Always wire report rows to stacktale.openReport so reports without source frames show the existing feedback instead of clicking silently.
  • Show the resolved errors-ai.log path in the Stacktale tree view description.
  • Hide Copy report for AI from the Command Palette because it requires a tree item context.
  • Add parser regression coverage for reports that do not include a source frame.

Why

Closes #6.

Verification

  • npm install
  • npm run compile
  • npm test
  • git diff --check

Notes

I could not run the VS Code Extension Development Host in this environment. The extension glue is covered by TypeScript compilation, and the no-frame report input is covered by parser regression coverage.

@GabrielBBaldez GabrielBBaldez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on the branch: tsc clean under strict, 4/4 parser tests including the new no-frame case, and CI green once I released the fork run.

The click path is the part I checked hardest, since that was the actual bug. openCulprit already had the "no source frame to open" message — attaching the command unconditionally is what makes it reachable, which is exactly right. Worth noting it now also covers the cases beyond a missing frame: a -1 line number and a non-ASCII filename both leave culprit undefined today (#5), and those rows stop being silent too.

asRelativePath(file, false) for the view description is the right call — a workspace-relative path is what tells you which service's log you're looking at in a monorepo, which is the half of #6 that is easy to underrate.

No changes requested. Not being able to run the Extension Development Host is fine — the parser coverage plus compilation is the right substitute, and I can exercise the host side.

@GabrielBBaldez
GabrielBBaldez merged commit f64ab4f into stacktale:main Jul 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking a report with no culprit frame silently does nothing, and the resolved log path is never shown

3 participants