Add a quiet argument to init_model_methods() and expose_functions() - #1285
Merged
Merged
Conversation
A package that calls these repeatedly, once per dataset, prints the "Compiling additional model methods..." notice each time with no way to turn it off short of suppressMessages(). quiet = TRUE drops the notices, including the "already compiled" ones from expose_functions(), while verbose keeps controlling the compiler output. Closes #914.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.0 #1285 +/- ##
=======================================
Coverage ? 93.13%
=======================================
Files ? 19
Lines ? 7312
Branches ? 0
=======================================
Hits ? 6810
Misses ? 502
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Closes #914
$init_model_methods()and$expose_functions()gainquiet = FALSE.With
quiet = TRUEthe "Compiling additional model methods...","Compiling standalone functions..." and "Functions already compiled"
messages are not printed. The
verboseargument still controls thecompiler output.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: