Reworded user's guide introduction to reduce_sum and lowered grainsize expections - #163
Merged
Merged
Conversation
…tions about what `grainsize = 1` can do. (design-doc #17)
2 tasks
wds15
reviewed
Apr 7, 2020
wds15
left a comment
wds15
left a comment
Contributor
There was a problem hiding this comment.
A few laundry comments... overall I am fine with your edits. Thanks.
mitzimorris
reviewed
Apr 7, 2020
mitzimorris
reviewed
Apr 7, 2020
mitzimorris
reviewed
Apr 7, 2020
Member
|
following your changes - perhaps too soon? |
Member
Author
|
@wds15, @mitzimorris ready again |
mitzimorris
reviewed
Apr 7, 2020
Member
Author
|
@wds15 All ready if yah wanna merge this up to the other pull and finish whatever needs to be done there. |
bbbales2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two edits I want to keep out of this are:
I changed the
reduce_sumintroduction stuff in the User's guide. It was difficult for me to read after taking a break and coming back.I also lowered expectations on what grainsize = 1 might do. I don't think we do have empirical evidence that grainsize = 1 always works. It might work, sure, but at least I only ever tried it in 1 model.
The other edits I liked but they could come or go.
Submission Checklist
Summary
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: