Explicitly test for empty distribution test changelist - #2869
Merged
Conversation
serban-nicusor-toptal
previously approved these changes
Jan 30, 2023
serban-nicusor-toptal
left a comment
serban-nicusor-toptal
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks
Member
Author
|
@serban-nicusor-toptal this still didn't work - is there a good way to print a Groovy variable for debugging? For some reason I guess the list isn't empty but also doesn't contain a test, so I'm worried the value is like |
WardBrian
dismissed stale reviews from serban-nicusor-toptal and syclik
via
January 30, 2023 20:24
1d8e47c
Member
Author
|
Okay, I think I figured it out. Using |
5 tasks
serban-nicusor-toptal
approved these changes
Jan 31, 2023
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on to #2864 after test failures in #2846. It seems that the list of changes being empty still tried to run some tests (I assumed the
forloop would just never execute) so this is making that conditional explicit.