[5.x] Fix failed slug validation when slug contains underscores - #10265
Merged
Merged
Conversation
o1y
changed the title
Member
|
Thanks. I wonder if we intentionally didn't allow underscores in slugs, even though the validation message says they are okay. I don't think it's a problem for them to contain underscores though. It's just a bit derpy looking but thats subjective. Unless I'm forgetting something, @jesseleite ? |
Contributor
|
Given the validation error message in my original PR, it seems underscores should be allowed. Maybe there's an edge case somewhere, where we don't want to allow underscores? ...but I cannot think of where! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10262