Skip to content

[5.x] Minor dark mode adjustments - #10544

Merged
jackmcdade merged 3 commits into
statamic:5.xfrom
heidkaemper:small-dark-mode-adjustments
Aug 1, 2024
Merged

jackmcdade merged 3 commits into
statamic:5.xfrom
heidkaemper:small-dark-mode-adjustments

Conversation

@heidkaemper

Copy link
Copy Markdown
Contributor

This pull request brings a few minor adjustments for dark mode:

  • The "little-dot" for indicating the publishing status gets a darker shade of grey. (will be the same color as "draft" in the status column of entry listings)
  • SVG icons in cp widget headers get the same same color as icons in the welcome widget.

Before:
before

After:
after

@jasonvarga jasonvarga left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

The status icons are good, but I think the widget icons need to go back the way they were. They were made darker on purpose.

I think the getting started widget icons should be made darker to match instead.

@heidkaemper

Copy link
Copy Markdown
Contributor Author

Sure, no problem, changes are made.
For my taste, the icons are a little too dark now. Maybe my monitor isn't calibrated properly. :-)

@jasonvarga

Copy link
Copy Markdown
Member

Thanks!

@jackmcdade
jackmcdade merged commit 400dbcc into statamic:5.x Aug 1, 2024
@dannyuk1982

Copy link
Copy Markdown
Contributor

The icons look too dark for me too (Calibrated LG Ultrafine), I can hardly see the darker ones in dark mode.

@jackmcdade

Copy link
Copy Markdown
Member

The icons look too dark for me too (Calibrated LG Ultrafine), I can hardly see the darker ones in dark mode.

Weird, they look good to me on the same exact monitor. I’ll have another look see.

@dannyuk1982

Copy link
Copy Markdown
Contributor

You're vision is likely better than mine, I've got light eyes so pretty light sensitive and also astigmatism, so my eyes aren't too good at seeing subtle contrast differences on dark backgrounds, especially on backlit screens

@jackmcdade

Copy link
Copy Markdown
Member

Well let's make it work for everyone : D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants