[6.x] Change shouldBootRootItems visibility in AddonServiceProvider#14831
Closed
marcorieser wants to merge 1 commit into
Closed
[6.x] Change shouldBootRootItems visibility in AddonServiceProvider#14831marcorieser wants to merge 1 commit into
shouldBootRootItems visibility in AddonServiceProvider#14831marcorieser wants to merge 1 commit into
Conversation
… inheriting classes can use it.
Member
|
What would you be changing? |
Contributor
Author
|
I want to publish to a directory in the config folder. |
Contributor
Author
|
Just realized that |
Member
|
I'll close this for the moment, but if you can show a full example of what you plan to do, we can revisit it. Changing a private method to protected means we need to think about how people would be overriding etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
shouldBootRootItemsvisibility from private to protected, so inheriting classes can use it.For example, I want to overwrite the logic of how my addon config is published and still prevent multiple boots by calling this from within the overwritten
bootConfig()method: