[4.x] Filter out any nulls from front end form checkboxes - #9212
Merged
Merged
Conversation
duncanmcclean
left a comment
duncanmcclean
left a comment
Member
There was a problem hiding this comment.
While this is now filtering out null values, it's also filtering out checked values which we don't want to be filtering out.
Contributor
Author
|
What do you mean by a checked value? |
Member
If I 'check' a checkbox, that doesn't get saved. |
Contributor
Author
|
Yeah but what is the value on the checkbox input? It would need to have a value=“something” for it not to be filtered. |
Member
|
Nevermind, I didn't add any options to the checkbox field. My bad! 🤦♂️ |
duncanmcclean
approved these changes
Dec 15, 2023
jesseleite
added a commit
that referenced
this pull request
Feb 28, 2025
A more proper fix for #9212.
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter out any null values in checkboxes on front end form requests.
The hidden input cant be removed as it was added to solve an issue on user profile forms.
Closes #9194