Skip to content

Add footer - #9

Merged
stefanv merged 5 commits into
statistical-python:mainfrom
jarrodmillman:footer
Sep 12, 2025
Merged

Add footer#9
stefanv merged 5 commits into
statistical-python:mainfrom
jarrodmillman:footer

Conversation

@jarrodmillman

@jarrodmillman jarrodmillman commented Jun 12, 2025

Copy link
Copy Markdown
Member

Waiting on next myst-theme release.

@jarrodmillman
jarrodmillman marked this pull request as draft June 12, 2025 19:37
@netlify

netlify Bot commented Jun 12, 2025

Copy link
Copy Markdown

Deploy Preview for statistical-python failed.

Name Link
🔨 Latest commit 2f953ec
🔍 Latest deploy log https://app.netlify.com/projects/statistical-python/deploys/684b2c6f2634ee0008b46bc9

@netlify

netlify Bot commented Jun 12, 2025

Copy link
Copy Markdown

Deploy Preview for statistical-python ready!

Name Link
🔨 Latest commit cc355c2
🔍 Latest deploy log https://app.netlify.com/projects/statistical-python/deploys/68714322599c1f00082c9aa8
😎 Deploy Preview https://deploy-preview-9--statistical-python.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@stefanv

stefanv commented Jun 24, 2025

Copy link
Copy Markdown
Member

New release is out!

@stefanv

stefanv commented Jul 11, 2025

Copy link
Copy Markdown
Member

pre-commit.ci autofix

@stefanv

stefanv commented Jul 11, 2025

Copy link
Copy Markdown
Member

@jarrodmillman Did you want to update footer content and perhaps color, and then we can get this in?

@brianhawthorne brianhawthorne self-assigned this Aug 19, 2025
@brianhawthorne

Copy link
Copy Markdown
Contributor

@jarrodmillman , can we get this merged? Note that this is not yet implemented in myst-theme (only jupyter-book/example-landing-pages), so we can't lean on that just yet.

Once this is deployed in the wild and we don't find any complaints, next step will be to implement upstream in myst-theme then lean on that and remove the styling here.

@stefanv
stefanv marked this pull request as ready for review September 4, 2025 20:01
@brianhawthorne

Copy link
Copy Markdown
Contributor

Hi @stefanv and @jarrodmillman , is anything blocking this PR from merge? It's been pending since June and I'd love to be able to mark it done.

@stefanv

stefanv commented Sep 10, 2025

Copy link
Copy Markdown
Member

@brianhawthorne Did you want to bring any of the updates over from the landing pages improvements? If not, we can merge this right now.

@brianhawthorne

brianhawthorne commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

@brianhawthorne Did you want to bring any of the updates over from the landing pages improvements? If not, we can merge this right now.

TL;DR: Please merge ASAP 😁

I'll do that in a follow-up changeset. I originally forked my copy from Jarrod's fork instead of this main repo, so I need to delete that and refork from here in order to make a proper PR. Also, this is Jarrod's PR, so I can't add commits anyway...

@stefanv
stefanv merged commit 559f665 into statistical-python:main Sep 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants