You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jarrodmillman , can we get this merged? Note that this is not yet implemented in myst-theme (only jupyter-book/example-landing-pages), so we can't lean on that just yet.
Once this is deployed in the wild and we don't find any complaints, next step will be to implement upstream in myst-theme then lean on that and remove the styling here.
@brianhawthorne Did you want to bring any of the updates over from the landing pages improvements? If not, we can merge this right now.
TL;DR: Please merge ASAP 😁
I'll do that in a follow-up changeset. I originally forked my copy from Jarrod's fork instead of this main repo, so I need to delete that and refork from here in order to make a proper PR. Also, this is Jarrod's PR, so I can't add commits anyway...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting on next myst-theme release.