refactor: avoid unnecessary assignment in blas/ext/base siblings#13328
Draft
Planeshifter wants to merge 1 commit into
Draft
refactor: avoid unnecessary assignment in blas/ext/base siblings#13328Planeshifter wants to merge 1 commit into
blas/ext/base siblings#13328Planeshifter wants to merge 1 commit into
Conversation
…dex-of` Propagates refactor from 3ceff10 ("refactor: avoid unnecessary assignment") to sibling last-index-of packages, collapsing the redundant `idx = N - 1 - idx; return idx;` sequence into a single return.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
refactor: avoid unnecessary assignment) to siblingblas/ext/base/*last-index-ofpackages, collapsing the redundantidx = N - 1 - idx; return idx;sequence into a singlereturn N - 1 - idx;. Target packages:blas/ext/base/dlast-index-ofblas/ext/base/slast-index-ofRelated Issues
None.
Questions
No.
Other
Validation: pattern search scoped to
blas/ext/base/*/lib/ndarray.js, followed by two independent adversarial passes and a style-consistency check confirming each target is textually identical to the source's pre-refactor shape. Deliberately excluded: the equivalentsrc/main.csequences in the same packages, since the source commit did not touch C.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by an automated Claude Code routine that propagates recent
developfixes to sibling packages with the same defect pattern. Pattern detection, candidate-site validation, and patch generation were AI-assisted; the resulting diff is the verbatim analog of 3ceff10.@stdlib-js/reviewers
Generated by Claude Code