test(@stdlib/net/http2-secure-server): renew expired self-signed test certificate#13330
Draft
Planeshifter wants to merge 1 commit into
Draft
test(@stdlib/net/http2-secure-server): renew expired self-signed test certificate#13330Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
… certificate
The `macos_test` workflow's Node.js v16 job failed on every scheduled
run against develop with `CERT_HAS_EXPIRED`
(`ERR_HTTP2_STREAM_CANCEL`) in test/test.js ("the server will use a
provided request listener"). Root cause: test/fixtures/localhost-cert.pem,
a self-signed CN=localhost certificate trusted by the test client via
`{ ca: CERT }`, expired 2025-09-15, so TLS validation fails
deterministically regardless of Node version or OS.
This commit regenerates the certificate with the existing, unchanged
private key (test/fixtures/localhost-privkey.pem), same CN=localhost
subject/issuer, valid for 20 years from today so the fixture does not
require frequent manual renewal.
Ref: https://github.com/stdlib-js/stdlib/actions/runs/28785523299
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
lib/node_modules/@stdlib/net/http2-secure-server/test/fixtures/localhost-cert.pem. The old certificate (CN=localhost) expired 2025-09-15.test/test.jsconnects its HTTP/2 client with{ ca: CERT }, trusting this certificate as its own CA, so once it expired, TLS validation failed deterministically on every run withCERT_HAS_EXPIRED/ERR_HTTP2_STREAM_CANCEL— this broke themacos_testworkflow's Node.js v16 job on every scheduled run againstdevelop. The new certificate uses the same, unchanged private key (test/fixtures/localhost-privkey.pem) and the sameCN=localhostsubject/issuer, valid for 20 years so the fixture doesn't need frequent manual renewal.Related Issues
None.
Questions
No.
Other
Found and fixed as part of automated CI-failure triage. Failing run: https://github.com/stdlib-js/stdlib/actions/runs/28785523299 (job:
macos_test, Node.js v16).Validated locally by regenerating the certificate with the existing private key, confirming the moduli match, and replicating the exact connection pattern used in
test/test.js(http2.connect(url, { ca: CERT })against a realhttp2.createSecureServer) — the request/response round-trip now completes without a TLS error. Reviewed by three independent passes (correctness, regression scope, style/conventions); all approved with no blocking findings.Note for a maintainer: the sibling
lib/node_modules/@stdlib/net/http2-secure-server/examples/localhost-cert.pem(a separate fixture, not used by the test suite) is also expired but out of scope for this fix since no CI job in the failure window exercises it.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code as part of an automated CI-failure triage and fix routine, based on live GitHub Actions job log analysis. The fix was reviewed by three independent automated review passes before being proposed here.
@stdlib-js/reviewers
Generated by Claude Code