chore: fix JavaScript lint errors (issue #14727) - #14746
Conversation
Add missing `.js` file extension to `bundle-collapser/plugin` require statement in stdlib-namespaces example, as required by the `stdlib/require-file-extensions` ESLint rule. Resolves stdlib-js#14727
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Ref: #14728 |
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Description
Adds the missing
.jsfile extension to thebundle-collapser/pluginrequire statement in the stdlib-namespaces example file.The
stdlib/require-file-extensionsESLint rule requires that require statements of files end with a whitelisted file extension (.js,.json,.node). Thebundle-collapserpackage includes aplugin.jsfile, so adding the extension is the correct fix.Related Issues
Resolves #14727
Changes
lib/node_modules/@stdlib/_tools/bundle/pkg-list/examples/stdlib-namespaces/index.js: Changedrequire( 'bundle-collapser/plugin')torequire( 'bundle-collapser/plugin.js')Checklist