Skip to content

chore: fix JavaScript lint errors (issue #14727) - #14746

Closed
Newer1107 wants to merge 1 commit into
stdlib-js:developfrom
Newer1107:fix/lint-require-extension
Closed

chore: fix JavaScript lint errors (issue #14727)#14746
Newer1107 wants to merge 1 commit into
stdlib-js:developfrom
Newer1107:fix/lint-require-extension

Conversation

@Newer1107

@Newer1107 Newer1107 commented Aug 28, 2026

Copy link
Copy Markdown

Description

Adds the missing .js file extension to the bundle-collapser/plugin require statement in the stdlib-namespaces example file.

The stdlib/require-file-extensions ESLint rule requires that require statements of files end with a whitelisted file extension (.js, .json, .node). The bundle-collapser package includes a plugin.js file, so adding the extension is the correct fix.

Related Issues

Resolves #14727

Changes

  • lib/node_modules/@stdlib/_tools/bundle/pkg-list/examples/stdlib-namespaces/index.js: Changed require( 'bundle-collapser/plugin') to require( 'bundle-collapser/plugin.js')

Checklist

Add missing `.js` file extension to `bundle-collapser/plugin` require
statement in stdlib-namespaces example, as required by the
`stdlib/require-file-extensions` ESLint rule.

Resolves stdlib-js#14727
@Newer1107
Newer1107 requested a review from a team August 28, 2026 10:21
@stdlib-bot stdlib-bot added the Tools Issue or pull request related to project tooling. label Aug 28, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Aug 28, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Aug 28, 2026
@kgryte

kgryte commented Aug 29, 2026

Copy link
Copy Markdown
Member

Ref: #14728

@kgryte kgryte added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Aug 29, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Aug 29, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants