Skip to content

feat: add C implementation for stats/base/ndarray/snanmskmin - #14755

Closed
AryanSharma48 wants to merge 6 commits into
stdlib-js:developfrom
AryanSharma48:feat-stats-base-ndarray-snanmskmin-c
Closed

feat: add C implementation for stats/base/ndarray/snanmskmin#14755
AryanSharma48 wants to merge 6 commits into
stdlib-js:developfrom
AryanSharma48:feat-stats-base-ndarray-snanmskmin-c

Conversation

@AryanSharma48

Copy link
Copy Markdown
Contributor

Part of #14034

Description

What is the purpose of this pull request?

This pull request:

  • adds the native C implementation for @stdlib/stats/base/ndarray/snanmskmin.
  • adds the Node-API boilerplate and tryRequire dispatcher to safely fall back to the pure JS implementation.
  • includes the required C benchmarks, native JS benchmarks, and C examples mirroring the canonical structure.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

  • No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution.

I utilized AI assistance to help implement the documentation, carefully adhering to the provided reference implementations and canonical @stdlib structures.

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Aug 28, 2026
@stdlib-bot

stdlib-bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/snanmskmax $\\color{red}121/123$
$\\color{green}+0.00\\%$
$\\color{red}3/4$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{red}121/123$
$\\color{green}+0.00\\%$
stats/base/ndarray/snanmskmin $\\color{green}185/185$
$\\color{green}+0.00\\%$
$\\color{green}7/7$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}185/185$
$\\color{green}+0.00\\%$
stats/base/ndarray/snanmskrange $\\color{red}121/123$
$\\color{green}+0.00\\%$
$\\color{red}3/4$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{red}121/123$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>
…d C variable

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>
… benchmark

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>
…t.main.js and test.native.js

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>
@AryanSharma48
AryanSharma48 marked this pull request as ready for review August 28, 2026 22:55
@AryanSharma48
AryanSharma48 requested a review from a team August 28, 2026 22:55
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 28, 2026
@AryanSharma48

Copy link
Copy Markdown
Contributor Author

Sorry about this PR, accidently commited other packages in this, closed this out!

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 28, 2026
@AryanSharma48
AryanSharma48 deleted the feat-stats-base-ndarray-snanmskmin-c branch August 30, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants