fix: get rid of glibc workarounds#198
Open
difcsi wants to merge 2 commits into
Open
Conversation
Owner
|
I suspect that these workarounds currently have no effect. I eventually had to take a different approach to the bug they were targeting, which was less of a bug than I first thought (#81). If so, I'd rather simply drop the workarounds than pushing additional assumptions into them (e.g. that the ld.so statically allocates certain link map structures, etc). |
difcsi
changed the title
Contributor
Author
|
@stephenrkell modified pr to drop workaround entirely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The glibc bugs workaround may crash if the ld.so malloc is uninstrumented and type information for link maps is available.