Generic L431C(B-C)(T-U) Variant - #2427
Merged
Merged
Conversation
fpistm
requested changes
Jul 9, 2024
fpistm
left a comment
fpistm
left a comment
Member
There was a problem hiding this comment.
Some minor changes to do and it will be ok for merge. Thanks.
fpistm
requested changes
Jul 9, 2024
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm
reviewed
Jul 9, 2024
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Contributor
Author
|
@fpistm anything else I need to do for this? |
fpistm
self-requested a review
July 12, 2024 15:23
Member
All is fine. I was OOO the last 4 days. 😉 Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding generic L431C(B-C)(T-U) board variants.
I followed the wiki guide, but this is the first new variant I've added, so hopefully I have done everything correctly!