fix: wrong preprocessor definitions - #61
Merged
Merged
Conversation
Wrong endif preprocessor placement when introducing new SD pins management. Fixes stm32duino#60 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Example for L4P5C(E-G)(T-U)_L4Q5CG(T-U). So ensure to have correct setup in this case. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm
marked this pull request as draft
July 6, 2023 17:24
fpistm
force-pushed
the
fix
branch
2 times, most recently
from
July 7, 2023 08:48
b2299fc to
1338e43
Compare
fpistm
marked this pull request as ready for review
July 7, 2023 08:55
For some series some PinMap_SD* are not available. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
This commit is a workaround waiting update of the core to specify which target have or not SDMMC signals. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60