Suppress error stack traces in production - #226
Merged
Conversation
When running in production, supress error stack traces from the error responses (pages). This change affects the global error handler used, it does not affect strong-remoting's REST handler. See strongloop/loopback#1502
Member
|
Not sure why the build failed. Otherwise LGTM. |
Member
Author
|
@slnode test please The tests failed because "No compatible version found: loopback@'>=2.22.0 <3.0.0". I think that the new version should have been published by now. |
Member
Author
|
"loopback-workspace.pr/label=ubuntu-iojs-3" is failing because of "ENOSPC: no space left on device, write", other slaves are green. I'll land this PR. |
bajtos
added a commit
that referenced
this pull request
Sep 3, 2015
…in-production Suppress error stack traces in production
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in production, supress error stack traces from the error responses (pages). This change affects the global error handler used, it does not affect strong-remoting's REST handler.
See strongloop/loopback#1502
/to @ritch please review
/cc @raymondfeng
It seems to me that adding an automated test is too much work & future maintenance, therefore I tested the change only manually.