ci: run yamllint on pull requests#971
Open
nielspardon wants to merge 2 commits into
Open
Conversation
Bring the GitHub Actions workflows under the 120-char line-length rule so the yamllint pre-commit hook passes without --no-verify: - Rename the Isthmus artifact via a working-directory instead of repeating the long nativeCompile path twice (release.yml, pr.yml). - Derive the release-bot email once as a step output and reference it, removing the duplicated long env lines (release.yml). - Scope a line-length disable/enable around the github-script step in pr_title.yaml: its long lines are prose inside a template literal where wrapping would change the rendered comment. The rest of the file stays checked.
nielspardon
force-pushed
the
ci/fix-yaml-line-length
branch
from
a200c28 to
8fc6a1a
Compare
nielspardon
changed the title
Add a Lint YAML job to the PR build workflow that runs the yamllint pre-commit hook (pinned config and version from .pre-commit-config.yaml) against all files, so YAML line-length and bracket violations are caught in CI instead of only locally.
nielspardon
force-pushed
the
ci/fix-yaml-line-length
branch
from
add7df7 to
b2df2e5
Compare
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yamllintis configured as a pre-commit hook but is not enforced in CI, so line-length and bracket violations have accumulated onmainand committing a touched workflow file requiresgit commit --no-verify. This adds a CI check and brings the existing workflows into compliance so the check passes.Enforce in CI
yamllintpre-commit hook against all files. It reuses the pinned config and version from.pre-commit-config.yaml(.yamllint.yaml, yamllint v1.33.0), keeping CI and local checks in lockstep.Fix existing violations
release.yml,pr.yml): use a stepworking-directoryinstead of repeating the longisthmus-cli/build/native/nativeCompile/path twice inmv(also drops the unusedvalue=capture).release.yml): derive the email once as an output of the bot-user-id step and reference it, removing the two duplicated longGIT_AUTHOR_EMAIL/GIT_COMMITTER_EMAILlines.pr_title.yaml: scope a# yamllint disable/enable rule:line-lengthpair around the github-script step — its long lines are prose inside a template literal, where wrapping would alter the rendered PR comment. The rest of the file stays checked.No behavior change to the workflows. Verified
pre-commit run yamllint --all-filespasses.🤖 Generated with AI