fix(picker): restore picker_width=false opt-out in session picker#410
Merged
sudo-tee merged 1 commit intoJun 8, 2026
Merged
Conversation
The cross-project session list (sudo-tee#403) added an `or 100` fallback when passing picker_width to base_picker.pick(). This silently converts `picker_width = false` into 100, bypassing the opt-out path that lets the picker backend use its own default window size.
Owner
|
Thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Setting
picker_width = falseto opt out of width overrides and let the picker backend use its own defaults no longer works for the session picker. Commitb977136(#403) introducedconfig.ui.picker_width or 100in @session_picker.lua, which silently convertsfalseinto100beforebase_picker.pick()ever sees it. Thefalse→nilopt-out conversion inM.pick()(added in #400) is never reached.Solution
Remove the
or 100fallback sopicker_widthis passed through as-is.M.pick()already handles all three cases: a number is used directly,nilfalls back toconfig.ui.picker_width, andfalseis converted tonilto let the backend decide its own window size.