Skip to content

Change Data.construct(from uint8Array:) return type from Data? to Data #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kateinoigakukun merged 1 commit into from
Jun 1, 2026
Merged

Change Data.construct(from uint8Array:) return type from Data? to Data #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/JavaScriptFoundationCompat/Data+JSValue.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ extension Data: ConvertibleToJSValue, ConstructibleFromJSValue {
public var jsValue: JSValue { jsTypedArray.jsValue }

/// Construct a Data from a JSTypedArray<UInt8>.
public static func construct(from uint8Array: JSTypedArray<UInt8>) -> Data? {
public static func construct(from uint8Array: JSTypedArray<UInt8>) -> Data {
// First, allocate the data storage
var data = Data(count: uint8Array.lengthInBytes)
// Then, copy the byte contents into the Data buffer
Expand Down
Loading