Skip to content

chore(tests): updated timed tests and other code smells#394

Merged
petruki merged 2 commits into
master-2from
staging
May 27, 2026
Merged

chore(tests): updated timed tests and other code smells#394
petruki merged 2 commits into
master-2from
staging

Conversation

@petruki
Copy link
Copy Markdown
Member

@petruki petruki commented May 27, 2026

This pull request primarily updates the documentation and test code to standardize the use of placeholder values and to migrate tests from the Switchers class to the new SwitchersBase class. It also improves test reliability by using a utility function to wait for snapshot updates instead of fixed delays.

Key changes include:

Documentation and Placeholder Updates:

  • Updated the README.md and code comments to use consistent placeholder values ([API_KEY], [DOMAIN_NAME], [COMPONENT_NAME]) instead of hardcoded or example strings for configuration properties and code samples. [1] [2] [3] [4] [5] [6]

Test Refactoring to SwitchersBase:

Test Configuration and Consistency:

  • Standardized test context configuration to use the same placeholder values and consistent setup across tests, including updating expected values in assertions. [1] [2] [3] [4]

Test Reliability Improvements:

  • Replaced fixed wait calls with a utility function (CountDownHelper.waitUntil) to more reliably wait for snapshot version updates in snapshot auto-update tests. [1] [2] [3] [4] [5]

@petruki petruki self-assigned this May 27, 2026
@petruki petruki added this to the v2.6.0 milestone May 27, 2026
@sonarqubecloud
Copy link
Copy Markdown

@petruki petruki merged commit 92c8117 into master-2 May 27, 2026
9 checks passed
@petruki petruki deleted the staging branch May 27, 2026 00:28
petruki added a commit that referenced this pull request May 27, 2026
* chore(tests): updated timed tests and other code smells

* fix(test): removed unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant