Skip to content

Update package manager#1137

Merged
ahoneybun merged 8 commits into
masterfrom
update-package-manager
Sep 12, 2023
Merged

Update package manager#1137
ahoneybun merged 8 commits into
masterfrom
update-package-manager

Conversation

@ahoneybun

@ahoneybun ahoneybun commented May 24, 2023

Copy link
Copy Markdown
Contributor

Address issue: #939

@ahoneybun ahoneybun requested review from a team and thomas-zimmerman May 24, 2023 17:55
thomas-zimmerman
thomas-zimmerman reviewed May 24, 2023
View reviewed changes

@thomas-zimmerman thomas-zimmerman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to be explicit on what files are helpful

thomas-zimmerman
thomas-zimmerman requested changes May 24, 2023
View reviewed changes

@thomas-zimmerman thomas-zimmerman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahoneybun Thoughts on the updated wording?

@n3m0-22 n3m0-22 self-assigned this May 24, 2023
n3m0-22
n3m0-22 suggested changes May 24, 2023
View reviewed changes

@n3m0-22 n3m0-22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commands work as expected, but I'm not sure about the capitalization of Apt/Dpkg. I would recommend it be swapped with APT/dpkg based on the Wikipedia pages.

@jacobgkau

jacobgkau commented May 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

For what it's worth, we used Apt at the beginning of sentences or titles a couple of times in the unfinished Pop!_Docs: https://github.com/pop-os/docs/blob/main/src/manage-apps/fix-packages.md, https://github.com/pop-os/docs/blob/main/src/manage-apps/using-terminal.md

Although it is technically APT according to upstream (or apt when referring to the command): https://salsa.debian.org/apt-team/apt

Debian does refer to Dpkg with that capitalization e.g. in the names of its development teams (as well as config flags), although they also use all-lowercase sometimes: https://wiki.debian.org/Teams/Dpkg, https://salsa.debian.org/dpkg-team

@thomas-zimmerman

thomas-zimmerman commented May 24, 2023

Copy link
Copy Markdown
Contributor

Updated article to address APT discussion. Please squish changes if merging.

@jacobgkau

jacobgkau commented May 24, 2023

Copy link
Copy Markdown
Member

Why'd you change Pop!_Shop to Pop Shop in the Pop article?

@ahoneybun

ahoneybun commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

Why'd you change Pop!_Shop to Pop Shop in the Pop article?

Should be fixed now.

@ahoneybun ahoneybun requested a review from n3m0-22 May 25, 2023 17:42
n3m0-22
n3m0-22 approved these changes May 25, 2023
View reviewed changes

@n3m0-22 n3m0-22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ahoneybun ahoneybun requested a review from a team August 3, 2023 19:40
Aaron Honeycutt and others added 6 commits August 3, 2023 15:17
@jacobgkau jacobgkau force-pushed the update-package-manager branch from 7c98669 to 50ae3e2 Compare August 3, 2023 21:17
@jacobgkau jacobgkau requested a review from a team August 3, 2023 22:35
thomas-zimmerman
thomas-zimmerman approved these changes Sep 12, 2023
View reviewed changes

@thomas-zimmerman thomas-zimmerman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to get these pending changes out. It looks like the APT/Dpkg concernss are addressed

@ahoneybun ahoneybun merged commit 7800619 into master Sep 12, 2023
@ahoneybun ahoneybun deleted the update-package-manager branch September 12, 2023 20:17
erinxocon pushed a commit that referenced this pull request Jun 23, 2026
@ahoneybun @thomas-zimmerman
Update package manager (#1137)
9aac60c 
* Update content

* Add commands

* Fix lint issue

* Update wording to directly mention files that will be created

* Pop!_Shop > Pop Shop
Update to not mention Pop Shop but Ubuntu Store -- Software & Updates

Update both for Apt > APT

* Fix spelling and formatting

---------

Co-authored-by: Aaron Honeycutt <aaronhoneycutt@proton.me>
Co-authored-by: Thomas Zimmerman <thomas@system76.com>
Co-authored-by: thomas-zimmerman <41023059+thomas-zimmerman@users.noreply.github.com>
erinxocon pushed a commit that referenced this pull request Jun 23, 2026
@ahoneybun @thomas-zimmerman
Update package manager (#1137)
922cee0 
* Update content

* Add commands

* Fix lint issue

* Update wording to directly mention files that will be created

* Pop!_Shop > Pop Shop
Update to not mention Pop Shop but Ubuntu Store -- Software & Updates

Update both for Apt > APT

* Fix spelling and formatting

---------

Co-authored-by: Aaron Honeycutt <aaronhoneycutt@proton.me>
Co-authored-by: Thomas Zimmerman <thomas@system76.com>
Co-authored-by: thomas-zimmerman <41023059+thomas-zimmerman@users.noreply.github.com>
erinxocon pushed a commit that referenced this pull request Jun 23, 2026
@ahoneybun @thomas-zimmerman
Update package manager (#1137)
ab19f7b 
* Update content

* Add commands

* Fix lint issue

* Update wording to directly mention files that will be created

* Pop!_Shop > Pop Shop
Update to not mention Pop Shop but Ubuntu Store -- Software & Updates

Update both for Apt > APT

* Fix spelling and formatting

---------

Co-authored-by: Aaron Honeycutt <aaronhoneycutt@proton.me>
Co-authored-by: Thomas Zimmerman <thomas@system76.com>
Co-authored-by: thomas-zimmerman <41023059+thomas-zimmerman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobgkau jacobgkau jacobgkau approved these changes
@thomas-zimmerman thomas-zimmerman thomas-zimmerman approved these changes
+1 more reviewer
@n3m0-22 n3m0-22 n3m0-22 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@n3m0-22 n3m0-22

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahoneybun @jacobgkau @thomas-zimmerman @n3m0-22