Add note about new 90% default start threshold#1163
Merged
Conversation
jacobgkau
reviewed
Aug 17, 2023
jacobgkau
approved these changes
Aug 17, 2023
Member
|
I assume we'll want to wait to merge this until the EC change is at least merged into EC master. (Ref: system76/ec#401) |
jackpot51
approved these changes
Aug 17, 2023
erinxocon
pushed a commit
that referenced
this pull request
Jun 23, 2026
erinxocon
pushed a commit
that referenced
this pull request
Jun 23, 2026
erinxocon
pushed a commit
that referenced
this pull request
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if the note needs to be more obvious, but this at least gets the info into this article.
Also corrected two instances of periods inside of parentheses. They should be outside.
Side note: further down, the "Proprietary firmware" section doesn't apply to the Pangolin. I might need to file an issue about that one.