Skip to content

fix builds for node 18+#1174

Merged
burden merged 2 commits into
masterfrom
node18
Sep 15, 2023
Merged

fix builds for node 18+#1174
burden merged 2 commits into
masterfrom
node18

Conversation

@burden

@burden burden commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

tested:

  • v18.17.1
  • v20.6.1

@ahoneybun ahoneybun requested review from a team September 15, 2023 19:06

@ahoneybun ahoneybun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the following so far:

  • Images load
  • Internal links work
  • Code blocks are good

@macifell macifell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@burden burden merged commit 36248f3 into master Sep 15, 2023
@burden burden deleted the node18 branch September 15, 2023 19:33
erinxocon pushed a commit that referenced this pull request Jun 23, 2026
* support for node 18

* update @system76/design
erinxocon pushed a commit that referenced this pull request Jun 23, 2026
* support for node 18

* update @system76/design
erinxocon pushed a commit that referenced this pull request Jun 23, 2026
* support for node 18

* update @system76/design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants