Skip to content

fix: don't default authSetting to ServerDefault in bulk user add #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacalata wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fix: don't default authSetting to ServerDefault in bulk user add #1779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06ebe9f
fix: don't default authSetting to ServerDefault in bulk user add
jacalata Jun 17, 2026
5ec82db
fix: update test to match corrected bulk add authSetting behaviour
jacalata Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tableauserverclient/server/request_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,8 +997,8 @@ def import_from_csv_req(self, csv_content: bytes, users: Iterable[UserItem]):
raise ValueError("User cannot have both authSetting and idpConfigurationId.")
elif user.idp_configuration_id is not None:
user_element.attrib["idpConfigurationId"] = user.idp_configuration_id
else:
user_element.attrib["authSetting"] = user.auth_setting or "ServerDefault"
elif user.auth_setting is not None:
user_element.attrib["authSetting"] = user.auth_setting

parts = {
"tableau_user_import": ("tsc_users_file.csv", csv_content, "file"),
Expand Down
2 changes: 1 addition & 1 deletion test/test_user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def test_bulk_add(server: TSC.Server) -> None:
for user, xml_user in zip(users, xml_users):
assert user.name == xml_user.get("name")
if user.idp_configuration_id is None:
assert xml_user.get("authSetting") == (user.auth_setting or "ServerDefault")
assert xml_user.get("authSetting") == user.auth_setting
else:
assert xml_user.get("idpConfigurationId") == user.idp_configuration_id
assert xml_user.get("authSetting") is None
Expand Down
Loading