Skip to content

Be more clear that always using the latest REST API version is recommended#859

Merged
bcantoni merged 2 commits into
gh-pagesfrom
encourage_use_server_version
Aug 24, 2021
Merged

Be more clear that always using the latest REST API version is recommended#859
bcantoni merged 2 commits into
gh-pagesfrom
encourage_use_server_version

Conversation

@bcantoni

@bcantoni bcantoni commented Jul 1, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@t8y8

t8y8 commented Jul 2, 2021

Copy link
Copy Markdown
Collaborator

We could make use_server_version=True the default on a new client instance, vs today where it's false by default

def __init__(self, server_address, use_server_version=False):

@bcantoni

bcantoni commented Jul 6, 2021

Copy link
Copy Markdown
Contributor Author

@t8y8 that's an interesting idea - but might that cause backwards-compability issues for people?

@t8y8

t8y8 commented Jul 6, 2021

Copy link
Copy Markdown
Collaborator

It shouldn't -- if they're upgrading their server already, they could still do so. They can also still manually set it after the fact and it'll override ServerInfo's call.

I don't think there are any calls that stop working outright between 2.3 and 3.X are there?

The version detection logic works all the way back to 9.0, if it's newer than API version 2.4 it will use ServerInfo but otherwise there's a legacy way to detect version.

The only reason we didn't do it originally is because we didn't want to "issue silent HTTP calls" but I think that's a very small price to pay to get people using the latest version.

They can also explicitly set it to False if for some reason they don't want it to fire off.

@bcantoni

Copy link
Copy Markdown
Contributor Author

Decided to include just the original text change here as an incremental improvement, moving the broader idea of changing the default to a new issue #876 so we can consider it separately.

@bcantoni bcantoni merged commit 1e58e56 into gh-pages Aug 24, 2021
@bcantoni bcantoni deleted the encourage_use_server_version branch August 24, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants