♻️ Extract terminal providers into workspace packages (#717)

.github/workflows/publish-packages.yml

@@ -30,7 +30,7 @@ jobs:
       - name: Validate the manifests declare this version
         run: |
           VERSION="${{ steps.resolve.outputs.value }}"
-          for f in packages/durable-streams/deno.json packages/runtime/deno.json packages/core/deno.json packages/acp/deno.json packages/testing/deno.json packages/test-agent/deno.json packages/web/deno.json packages/workflow/deno.json packages/cli/deno.json packages/code-review-agent/deno.json; do
+          for f in packages/durable-streams/deno.json packages/runtime/deno.json packages/terminal/deno.json packages/core/deno.json packages/acp/deno.json packages/terminal-tmux/deno.json packages/testing/deno.json packages/test-agent/deno.json packages/web/deno.json packages/workflow/deno.json packages/cli/deno.json packages/code-review-agent/deno.json; do
             declared="$(jq -r .version "$f")"
             if [ "$declared" != "$VERSION" ]; then
               echo "::error::$f declares $declared, not $VERSION — the tag does not match the manifests"
@@ -75,20 +75,34 @@ jobs:
       package: packages/runtime
       version: ${{ needs.version.outputs.value }}
 
+  terminal:
+    needs: [version, durable-streams]
+    uses: ./.github/workflows/publish-one.yml
+    with:
+      package: packages/terminal
+      version: ${{ needs.version.outputs.value }}
+
   core:
-    needs: [version, durable-streams, runtime]
+    needs: [version, durable-streams, runtime, terminal]
     uses: ./.github/workflows/publish-one.yml
     with:
       package: packages/core
       version: ${{ needs.version.outputs.value }}
 
   acp:
-    needs: [version, core, runtime]
+    needs: [version, core, runtime, terminal]
     uses: ./.github/workflows/publish-one.yml
     with:
       package: packages/acp
       version: ${{ needs.version.outputs.value }}
 
+  terminal-tmux:
+    needs: [version, terminal]
+    uses: ./.github/workflows/publish-one.yml
+    with:
+      package: packages/terminal-tmux
+      version: ${{ needs.version.outputs.value }}
+
   testing:
     needs: [version, core, durable-streams, runtime]
     uses: ./.github/workflows/publish-one.yml
@@ -97,7 +111,7 @@ jobs:
       version: ${{ needs.version.outputs.value }}
 
   test-agent:
-    needs: [version, acp, core, durable-streams, runtime, testing]
+    needs: [version, acp, core, durable-streams, runtime, terminal, testing]
     uses: ./.github/workflows/publish-one.yml
     with:
       package: packages/test-agent
@@ -118,7 +132,7 @@ jobs:
       version: ${{ needs.version.outputs.value }}
 
   cli:
-    needs: [version, acp, core, durable-streams, runtime, test-agent, testing, web, workflow]
+    needs: [version, acp, core, durable-streams, runtime, terminal, terminal-tmux, test-agent, testing, web, workflow]
     uses: ./.github/workflows/publish-one.yml
     with:
       package: packages/cli

packages/acp/package.json

@@ -11,6 +11,7 @@
     "@agentclientprotocol/sdk": "1.3.0",
     "@executablemd/core": "workspace:*",
     "@executablemd/runtime": "workspace:*",
+    "@executablemd/terminal": "workspace:*",
     "acpx": "0.12.0",
     "effection": "4.1.0"
   }

packages/acp/src/provider.ts

@@ -88,8 +88,8 @@ import {
   AgentSessionRecoveryRequired,
   cwd,
   ExecutableObservationError,
-  nativeLaunch,
 } from "@executablemd/runtime";
+import { nativeLaunch } from "@executablemd/terminal";
 import type {
   AgentSessionCoordinator,
   AgentSessionKey,

packages/acp/tests/native-launch.test.ts

@@ -27,13 +27,10 @@ import type {
   PreparedLaunchRecord,
   Session,
 } from "@executablemd/core";
-import {
-  flushOutput,
-  installControlledLauncher,
-  NativeLauncher,
-  reserveTerminal,
-} from "@executablemd/runtime";
-import type { AgentSessionCoordinator, NativeLaunchRequest } from "@executablemd/runtime";
+import { flushOutput, NativeLauncher, reserveTerminal } from "@executablemd/terminal";
+import { installControlledLauncher } from "@executablemd/terminal/test";
+import type { AgentSessionCoordinator } from "@executablemd/runtime";
+import type { NativeLaunchRequest } from "@executablemd/terminal";
 import { createAcpxProvider } from "../src/provider.ts";
 import type { AcpxProviderDependencies } from "../src/provider.ts";
 import {

packages/cli/package.json

@@ -16,6 +16,8 @@
     "@executablemd/core": "workspace:*",
     "@executablemd/durable-streams": "workspace:*",
     "@executablemd/runtime": "workspace:*",
+    "@executablemd/terminal": "workspace:*",
+    "@executablemd/terminal-tmux": "workspace:*",
     "@executablemd/test-agent": "workspace:*",
     "@executablemd/testing": "workspace:*",
     "@executablemd/web": "workspace:*",

packages/cli/src/agent-stack.ts

@@ -21,9 +21,10 @@ import {
   registerAgentProvider,
 } from "@executablemd/core";
 import type { AgentProviderFactory, PermissionMode } from "@executablemd/core";
-import { installForegroundLauncher, env as readEnv } from "@executablemd/runtime";
-import { unsupportedTerminalGrid } from "./terminal/host.ts";
-import type { TerminalGridInstaller } from "./terminal/host.ts";
+import { env as readEnv } from "@executablemd/runtime";
+import { installForegroundLauncher } from "@executablemd/terminal/posix";
+import { unsupportedTerminalGrid } from "./grid-host.ts";
+import type { TerminalGridInstaller } from "./grid-host.ts";
 import { createAcpxProvider, DEFAULT_AGENT_NAME } from "@executablemd/acp";
 import type { AcpxProviderDependencies } from "@executablemd/acp";
 // A separate entrypoint because the embedded adapters are temporary (#636) and

packages/cli/src/cli.ts

@@ -96,8 +96,8 @@ import { installWebComponents, installWebElicitation } from "@executablemd/web";
 import { timebox } from "@effectionx/timebox";
 import { timeout as runTimeout } from "@executablemd/runtime";
 import { installRunAgentStack, resolveAgentStack, resolveAuthorshipStack } from "./agent-stack.ts";
-import { unsupportedTerminalGrid } from "./terminal/host.ts";
-import type { TerminalGridInstaller } from "./terminal/host.ts";
+import { unsupportedTerminalGrid } from "./grid-host.ts";
+import type { TerminalGridInstaller } from "./grid-host.ts";
 import { planComponentDeclaration } from "./plan-component.ts";
 import { planAgentContext } from "./authorship-profile.ts";
 import { useVerboseComponent } from "./verbose-component.ts";

packages/cli/src/compiled.ts

@@ -19,8 +19,8 @@ import {
   isCredentialHelperMode,
   runCredentialHelper,
 } from "@executablemd/workflow/credential-helper";
-import { paneWorkerInvocation, runPaneWorkerProcess } from "./terminal/pane-worker.ts";
-import { foregroundTerminalGrid } from "./terminal/host.ts";
+import { paneWorkerInvocation, runPaneWorkerProcess } from "@executablemd/terminal-tmux";
+import { foregroundTerminalGrid } from "./grid-host.ts";
 import type { HelperAssembly } from "@executablemd/workflow/credential-helper";
 import { useCompiledService } from "./compiled-service.ts";
 

packages/cli/src/deno.ts

@@ -22,8 +22,8 @@ import {
   isCredentialHelperMode,
   runCredentialHelper,
 } from "@executablemd/workflow/credential-helper";
-import { paneWorkerInvocation, runPaneWorkerProcess } from "./terminal/pane-worker.ts";
-import { foregroundTerminalGrid } from "./terminal/host.ts";
+import { paneWorkerInvocation, runPaneWorkerProcess } from "@executablemd/terminal-tmux";
+import { foregroundTerminalGrid } from "./grid-host.ts";
 import type { HelperAssembly } from "@executablemd/workflow/credential-helper";
 import { useDenoService } from "./deno-service.ts";