[sync] fix: keep tables ready after update failures T4661#3216
[sync] fix: keep tables ready after update failures T4661#3216tea-artist wants to merge 1 commit into
Conversation
Synced from teableio/teable-ee@747c8dc Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jocky-Teable <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de89c714c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ((await this.cacheService.get(key)) === this.owner) { | ||
| await this.cacheService.del(key); |
There was a problem hiding this comment.
Release Redis lock with atomic owner check
Replace the separate get + del sequence with an atomic compare-and-delete (e.g., a Lua script), because the current code can delete another instance’s lock under contention. If this process reads its own token, then the key expires and another instance acquires the same lock before del runs, del will remove the new owner’s lock and allow overlapping execution of the protected critical section.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
🔄 Automated sync from EE repository.
46 commit(s) synced since last sync.
Authors
Included commits
Latest source commit: teableio/teable-ee@747c8dc
This PR was automatically created by the sync workflow.