remove reset_heartbeats field in ResetActivityExecutionRequest - #820
Merged
Conversation
5 tasks
fretz12
reviewed
Jul 9, 2026
|
|
||
| // If activity is paused, it will remain paused after reset | ||
| bool keep_paused = 7; | ||
| bool keep_paused = 6; |
Contributor
There was a problem hiding this comment.
I'm assuming swapping is ok if no one uses this API?
Safe thing to do is:
reserved 6;
reserved "reset_heartbeat";
// If activity is paused, it will remain paused after reset
bool keep_paused = 7;
...
Contributor
There was a problem hiding this comment.
Agree it's OK to renumber: ResetActivityExecutionRequest has always returned an error.
| - WIRE_JSON | ||
| ignore: | ||
| ignore_only: |
Contributor
There was a problem hiding this comment.
if we did my above comment, I don't think we need this
Contributor
Author
There was a problem hiding this comment.
Agree we can swap, but since this has never been used server side I think it is cleaner to remove
dandavison
approved these changes
Jul 14, 2026
|
|
||
| // If activity is paused, it will remain paused after reset | ||
| bool keep_paused = 7; | ||
| bool keep_paused = 6; |
Contributor
There was a problem hiding this comment.
Agree it's OK to renumber: ResetActivityExecutionRequest has always returned an error.
maciejdudko
approved these changes
Jul 14, 2026
spkane31
added a commit
to temporalio/temporal
that referenced
this pull request
Jul 15, 2026
## What changed? Resetting an activity execution now always clears heartbeat details. temporalio/api#820 Removes the `reset_heartbeat` field from the Request message. ## Why? This change simplifies the API surface and we (the engineering/product team) do not see a good use case for resetting an activity and keeping heartbeat data. If this is needed or there is a big customer ask for it we can add this back in the future. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [X] covered by existing tests - [X] added new unit test(s) - [X] added new functional test(s) ## Potential risks Minimal, PR is into a feature branch
dandavison
added a commit
that referenced
this pull request
Aug 4, 2026
This PR reverts "remove reset_heartbeats field in ResetActivityExecutionRequest (#820 e74dc68)" **What changed?** - Add reset_heartbeats field to ResetActivityExecutionRequest **Why?** - Parity with WFA - This product behavior makes sense: a user with a long-running activity using exponential backoff on attempt 10 may wish to reset the attempt counter in order that the next retry backoff is short, and yet preserve their checkpointed progress. **Breaking changes** No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Remove the
reset_heartbeatfield fromtemporal.api.workflowservice.v1.ResetActivityExecutionRequest.Why?
The new default behavior will be to reset heartbeats with a reset request so this field is no longer needed.
Breaking changes
This is technically a breaking change, but this endpoint has not been published in the server yet so no users can actually use this field.
Server PR
N/A