COM-132: Add GCP Cloud Run support to worker deployment version command - #1103
Merged
Conversation
…ion commands Mirror the AWS Lambda support: four --gcp-cloud-run-* flags on create-version and update-version-compute-config, writing a gcp-cloud-run ComputeConfig provider.
gcristea-temporal
force-pushed
the
feature/gcp_cloud_run
branch
from
July 9, 2026 02:59
370ef6f to
c9a5bbb
Compare
gcristea-temporal
marked this pull request as ready for review
July 9, 2026 03:14
chaptersix
reviewed
Jul 13, 2026
chaptersix
approved these changes
Jul 18, 2026
ks-temporal
pushed a commit
that referenced
this pull request
Jul 31, 2026
## Related issues Backports #1103 and #1135. ## What changed? Backports GCP Cloud Run Worker Deployment Version support and its min/max/initial instance and utilization-target scaling options to `release/1.8.x`. PR #1103 is included as the direct prerequisite for #1135. ## Validation - `go test ./...` - Regenerated `internal/temporalcli/commands.gen.go` and confirmed it is unchanged - Confirmed module files are unchanged ## Risk This adds experimental Worker Deployment compute-configuration flags to the 1.8 release branch. --------- Co-authored-by: gcristea-temporal <george.cristea@temporal.io> Co-authored-by: Zain Awais <125117323+zainawaisn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the AWS Lambda support: four
--gcp-cloud-run-*flags oncreate-versionandupdate-version-compute-config, writing a gcp-cloud-run ComputeConfig provider.Related issues
What changed?
Add GCP Cloud Run worker pools as a compute provider
Lets an operator point a Worker Deployment Version at a GCP Cloud Run worker pool, mirroring the existing AWS Lambda support 1:1. CLI-only — serializes the four detail keys WCI reads (
project,region,worker_pool,service_account)Changes
--gcp-cloud-run-*flags oncreate-versionandupdate-version-compute-config, plus usage examples.shared
computeProviderConfigselector that enforces AWS/GCP mutualexclusivity and dispatches on the trigger flag. Both
runmethods rewired.TestCreateWorkerDeploymentVersion_Errors; a skipped round-trip testmirrors the Lambda one (needs real GCP fixtures).
Checklist
Stability
-o json/-o jsonl) are treated as breaking changesDesign
temporal <noun> <verb>structure (e.g.temporal workflow start)--search-attribute, bad:--index-field)(Experimental)incommands.yamlHelp text (see style guide at the top of
commands.yaml)--namespace, not-n), one flag per lineYourXxxform (YourWorkflowId,YourNamespace)Behavior
Tests
SharedServerSuite)func TestXxx) where applicableManual tests
Setup
Happy path
Error case
Composition