restruct sentry proj - #79
Conversation
cretz
left a comment
There was a problem hiding this comment.
Thanks! Moving workflows to a separate file is definitely a good thing these days. Just need to get that activity back in there and I think we'll be good.
cretz
left a comment
There was a problem hiding this comment.
Please make sure you run poe lint before pushing (poe format will fix the formatting issues)
There was a problem hiding this comment.
I think you should update the starter.py to reference the workflow from this file and not through the worker.py file
Co-authored-by: Chad Retz <chad.retz@gmail.com>
Co-authored-by: Chad Retz <chad.retz@gmail.com>
|
The restructure you proposed here has since landed in Since the change is no longer applicable to the current sample, I'm closing this out. |
The code in /sentry currently does not run.
Separating the workflow code into its own file resolves the issue
What was changed
Moved greetings workflow to workflows.py and import workflow within worker
Why?
So others can reference this sample and have no issue running it without alterations being made
Checklist
Closes
How was this tested:
Followed run instructions in README.md. Outputs:
No