Fix dotenv get exiting with code 1 for empty string values - #700
Open
ShamikOfficial wants to merge 2 commits into
Open
Fix dotenv get exiting with code 1 for empty string values#700ShamikOfficial wants to merge 2 commits into
ShamikOfficial wants to merge 2 commits into
Conversation
Empty KEY= values are valid; the CLI truthiness check treated them as missing. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #699.
Problem
dotenv get KEYusesif stored_value:so an empty string is treated as missing and the command exits with code 1 — the same as an absent key.Empty values (
KEY=/KEY="") are valid; only the CLI was wrong.Fix
Exit only when the key is absent or the stored value is
None(bare key with no value). Empty strings are echoed and exit 0.Tests
test_get_empty_string_valuepins exit code 0 and a blank line of output fora=.pytest tests/test_cli.py::test_get_existing_value tests/test_cli.py::test_get_empty_string_value tests/test_cli.py::test_get_non_existent_value— 3 passed.