Conversation
rewrite() already knows how to do this, we just were not passing follow_symlinks through from the CLI so a linked .env would get replaced by a regular file. Fixes theskumar#541.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
.envis a symlink,dotenv set/dotenv unsetwas rewriting the link itself instead of the target file. Ended up with a regular file where the symlink used to be.set_key/unset_keyalready support this viafollow_symlinks=True, the CLI just wasn't passing it. Library default is unchanged.Fixes #541
Test plan
.envif you have one lying around