ASoC: Intel: soc-acpi-intel-arl-match: Add rt722 and rt1320 support#5187
Conversation
| .aggregated = 0, | ||
| .group_position = 0, | ||
| .group_id = 0, | ||
| }, |
There was a problem hiding this comment.
We need to remove the Speaker endpoint if it is not used.
There was a problem hiding this comment.
yeah, but there's no way to know is the speaker on the RT1320 is the only one in the system, or if it's used as a companion to that of the RT722.
The notion of endpoint was already not super useful and mostly introduced as a way to predict the future with audio composition, but it's already obsolete in that endpoints are now optional.... We'd need to check if the functions are described in ACPI for sure.
There was a problem hiding this comment.
@charleskeepax has a good suggestion on #5186 that can make a DAI be optional and present by default.
There was a problem hiding this comment.
@charleskeepax has a good suggestion on #5186 that can make a DAI be optional and present by default.
@bardliao, thank you for your advice. By referencing @charleskeepax #5186 suggestion on cs42l43, I could apply the quirk_exclude codes into RT722 as a short-term once #5186 merged. In the end, #5188 implementing the "endpoints present by sdca acpi function" will be a final solution afterwards.
macchian
force-pushed
the
sof-dev-20240809
branch
from
6cfb1f0 to
97b948c
Compare
macchian
requested review from
dbaluta,
kv2019i,
lgirdwood,
ranj063 and
ujfalusi
as code owners
|
LGTM. But the commits should re-order. ASoC: sdw_utils: Add quirk to exclude amplifier function should be the first commit. Also, please mention rt721 in the commit message. |
macchian
force-pushed
the
sof-dev-20240809
branch
2 times, most recently
from
f078921 to
504bfc3
Compare
@bardliao ,thanks for your comments. Done. |
When SKUs use the multi-function codec, which integrates Headset, Amplifier and DMIC. The corresponding quirks provide options to support internal amplifier/DMIC or not. In the case of RT722, this SKU excludes the internal amplifier and use an additional amplifier instead. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
This patch adds a quirk to include the codec amplifier function for this Dell SKU. Note: In this SKU '0CF0', the RT722 codec amplifier is excluded, and an external amplifier is used instead. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
This patch adds support for the rt722 multi-function codec and the rt1320 amplifier in the ARL board configuration. Link 0: RT722 codec with three endpoints: Headset, Speaker, and DMIC. Link 2: RT1320 amplifier. Note: The Speaker endpoint on the RT722 codec is not used. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
macchian
force-pushed
the
sof-dev-20240809
branch
from
504bfc3 to
f75b7fd
Compare
|
These PRs has been verified on board. We can merge now. |
3 participants
This patch adds support for the rt722 multi-function codec and the rt1320 amplifier in the ARL board configuration.
Link 0: RT722 codec with three endpoints: Headset, Speaker, and DMIC.
Link 2: RT1320 amplifier.
Note:
The Speaker endpoint on the RT722 codec is not used.