acp: add TDM DAI and DMA support for ACP 7.0#10761
Open
Sivasubramanian678 wants to merge 2 commits into
Open
Conversation
Sivasubramanian678
requested review from
abonislawski,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
lgirdwood,
lyakh,
mmaka1,
pblaszko,
plbossart and
tmleman
as code owners
Collaborator
|
Can one of the admins verify this patch?
|
Contributor
Author
|
Dependency: This PR depends on zephyrproject-rtos/zephyr#108314 for native Zephyr ACP 7.0 TDM driver enablement. |
lyakh
reviewed
May 11, 2026
| } else { | ||
| tdm_ctx = (struct tdm_context *)tdm_data->dai_index_ptr; | ||
| } | ||
| tdm_ctx->index = dd->dai->index; |
| struct tdm_context *tdm_ctx; | ||
| if (!tdm_data->dai_index_ptr) { | ||
| tdm_ctx = rzalloc(SOF_MEM_FLAG_USER | SOF_MEM_FLAG_COHERENT, | ||
| sizeof(*tdm_ctx)); |
Collaborator
There was a problem hiding this comment.
does it have to be uncached because it's accessed from different contexts? Maybe you need a comment for that
Member
|
Will run CI. |
Member
|
test this please |
lyakh
requested changes
May 12, 2026
bhiregoudar
approved these changes
May 12, 2026
Member
|
@Sivasubramanian678 pls see CI, lots of build failures showing |
Contributor
Author
Dependency: This PR depends on zephyrproject-rtos/zephyr#108314 for native Zephyr ACP 7.0 TDM driver enablement. So we have to wait till zephyr PR's merge. |
Add TDM DAI and DMA support for the AMD ACP 7.0 platform with three instances: HS, SP, and BT. Signed-off-by: Siva Subramanian Ravi Saravanan <sravisar@amd.com>
lyakh
approved these changes
May 29, 2026
Collaborator
oh, ouch... how have I missed it?? Sorry! Shouldn't happen actually... |
This updates the Zephyr revision to include TDM DAI and DMA driver support for AMD ACP 7.0: 45bdb70e1c0 dma: amd: add TDM DMA driver for AMD ACP 7.0 a8fde10b0ed dai: amd: add TDM DAI driver and register definitions for ACP 7.0 Signed-off-by: Siva Subramanian Ravi Saravanan <sravisar@amd.com>
Collaborator
|
This now hits same failure on NXP IMX95 as hits previous attempt to upgrade Zephyr (see latest status in #10765 (comment) ). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TDM DAI and DMA support for the AMD ACP
7.0 platform with three instances: HS, SP, and BT.