Conversation
13 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a nix flake that builds
thtk.while I was working on it I found that the installed
thtk.pcis broken. building current master with a simple/usr/localprefix:pkg-config --cflags --libs thtkreturns-I -L -lthtk, so consumers get no include path and no library path.this is caused by thtk/CMakeLists.txt:30 calling
configure_file()without passing@ONLYas an argument, so CMake substitutes both variable forms:@VAR@and${VAR}. The pkg-config variable references in thtk/thtk.pc.in get eaten by CMake eagerly expanding them.also, the paths in thtk.pc.in were built as
${prefix}/@CMAKE_INSTALL_INCLUDEDIR, which assumes those variables are relative. replacing the path construction with@CMAKE_INSTALL_FULL_INCLUDEDIRhandles absolute paths correctly. Same for theLIBDIRpath construction.Notably, the currently open nixpkgs thtk pull request includes a hack designed to work around this issue. Not entirely relevant, but wanted to point it out to prove that it's not just an issue with my environment. (I also based the derivation in the flake on the one in that PR)
This PR includes both the fixes for the build system and the nix flake.