feat: add support for global ip filters#567
Conversation
📝 WalkthroughWalkthroughAdds global IP allow/block configuration to auth flow, merges global and app-specific IP filters in AuthService.CheckIP, and renames IsResourceAllowed → IsUserAllowed with corresponding controller wiring updates. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ProxyController
participant AuthService
participant Config
Client->>ProxyController: request with user/app context
ProxyController->>AuthService: IsUserAllowed(ctx, userContext, appAcls)
AuthService->>Config: read global IP config (auth.cfg.IP)
AuthService-->>AuthService: merge global IP lists with appAcls IP lists
AuthService-->>ProxyController: allow/deny result
ProxyController-->>Client: 200 or 401/403 response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 19.25% 19.23% -0.03%
==========================================
Files 39 39
Lines 2295 2298 +3
==========================================
Hits 442 442
- Misses 1825 1828 +3
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Solves #516.
Summary by CodeRabbit
New Features
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.