Modify retry() to take a callable and enforce the timeout

[categulario]

Previous implementation is equivalent to return True. This implementation, while API incompatible, is easy to use (I would modify the corresponding code in tmuxp myself) and enforces the timeout via an exception, which would help debugging since it provide the specific cause.

API docs updated accordingly. Environment variable preserved.

fixes #368 and addresses tmux-python/tmuxp#704 (comment) , it would also help with tmux-python/tmuxp#620

[CLAassistant]

All committers have signed the CLA.

[tony]

@categulario poetry run flake8 and fix those, and it should let the rest of the tests run

[codecov]

Codecov Report

Merging #372 (8f555e5) into master (897bd24) will increase coverage by 0.41%.
The diff coverage is 98.43%.

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   88.13%   88.54%   +0.41%     
==========================================
  Files          15       16       +1     
  Lines        1500     1563      +63     
==========================================
+ Hits         1322     1384      +62     
- Misses        178      179       +1     

Impacted Files	Coverage Δ
libtmux/test.py	51.76% <93.75%> (+8.90%)	⬆️
libtmux/exc.py	100.00% <100.00%> (ø)
tests/test_test.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897bd24...8f555e5. Read the comment docs.

[categulario]

In the latest commits I even added three tests

[tony]

@categulario

• Original: b8c2569
• Rebased via github: c041514
• My squash / interactive rebase via rebase -i: 036642e

[tony]

@categulario merged in

v0.12.0a0: branch, pypi

I will need to drop python 3.7 and 3.8 in tmuxp since that's happening in libtmux before 0.12.0a0 can be added to tmuxp: tmux-python/tmuxp#763

[tony]

i will update this

• tmuxp v1.12.0a0: Drop 3.7 + 3.8 for libtmux compatibility: branch pypi
• tmuxp v1.12.0a1: Update libtmux package for retry_until branch, pypi

[tony]

tmux-python/tmuxp#776 has a concept of retry_until() with assert retry_until(..., raises=False)

[tony]

@categulario As a next step you are welcome to make a PR moving retry() -> retry_until() in tmuxp.

if you do have something started let me know, if not i will get to it during the weekend. I have an example at tmux-python/tmuxp#776

[categulario]

I will need to drop python 3.7 and 3.8 in tmuxp since that's happening in libtmux before 0.12.0a0 can be added to tmuxp: tmux-python/tmuxp#763

Is that necessary? python 3.7 is still maintained. and 3.8 comes in ubuntu 20.04. What exactly makes libtmux incompatible?

@categulario As a next step you are welcome to make a PR moving retry() -> retry_until() in tmuxp.

Sure thing!

[tony]

Is that necessary? python 3.7 is still maintained. and 3.8 comes in ubuntu 20.04. What exactly makes libtmux incompatible?

I thought about that.

I can look at reversing it, but I'd need to do it in libtmux first. See #374

[tony]

I can expand #374 to cover 3.7 (this would need to happen during the weekend though)

[tony]

@categulario libtmux and tmuxp support python 3.7 and 3.8 again ✅

• libtmux v0.12.0a1 branch, pypi
• tmuxp v1.12.0a2 branch, pypi

Do you still want to move the tests over to retry_until() (if so do you have an ETA?) If not I can try to do it in the weekend

P.S. It's open source, none of us our paid, but the reason I hurry is the warnings due to the DeprecationWarning I added to retry()😄 :

[categulario]

What is causing the warnings? I'm still interested in doing it. My eta would be the night of the Saturday which for you is the morning of the Saturday. I'm in UTC+8 El sáb., 21 de mayo de 2022 07:42, Tony Narlock ***@***.***> escribió:

…

@categulario <https://github.com/categulario> libtmux and tmuxp support python 3.7 and 3.8 again ✅ - libtmux v0.12.0a1 branch <https://github.com/tmux-python/libtmux/tree/v0.12.0a1>, pypi <https://pypi.org/project/libtmux/0.12.0a1/> - tmuxp v1.12.0a2 branch <https://github.com/tmux-python/tmuxp/tree/v1.12.0a2>, pypi <https://pypi.org/project/tmuxp/1.12.0a2/> Do you still want to move the tests over to retry_until() (if so do you have an ETA?) If not I can try to do it in the weekend P.S. It's open source, none of us our paid, but the reason I press somewhat is the warnings 😄 : [image: image] <https://user-images.githubusercontent.com/26336/169625130-fe6dd0d7-246a-47e2-a40e-9321b086c408.png> — Reply to this email directly, view it on GitHub <#372 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGBBZB3O3XNSXTP2UASHFLVLAPPTANCNFSM5WDL2JPQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tony]

What is causing the warnings?
The warnings are from retry() being used in test_workspacebuilder.py (which should be resolved by moving to retry_until()

P.S. And the remainder - in python 3.10 - are from the user distutils.Version (which I'll get around to fixing soon)

I'm still interested in doing it. My eta would be the night of the Saturday which for you is the morning of the Saturday. I'm in UTC+8

That sounds good to me