fix(#2057): return ordered cycle path array instead of parent mapping in detectUndirectedCycle - #2198
Open
gonzoblasco wants to merge 1 commit into
Open
fix(#2057): return ordered cycle path array instead of parent mapping in detectUndirectedCycle#2198gonzoblasco wants to merge 1 commit into
gonzoblasco wants to merge 1 commit into
Conversation
… mapping in detectUndirectedCycle The function was returning an object mapping vertex keys to their parent vertices, which is not a standard cycle representation. Changed to return an ordered array of vertices forming the cycle, starting and ending at the same vertex. Fixes trekhleb#2057
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
detectUndirectedCyclefunction was returning an object mapping vertex keys to their parent vertices (e.g.{ B: vertexC, C: vertexD, D: vertexE, E: vertexB }), which is not a standard cycle representation and may not be intuitive for consumers expecting an ordered path.This PR changes the return value to an ordered array of vertices forming the cycle, starting and ending at the same vertex (e.g.
[vertexB, vertexC, vertexD, vertexE, vertexB]).Changes
Testing
Fixes #2057