feat: updates CLI to use https flag - #814
Merged
matt-aitken merged 5 commits intoJan 12, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 3fdcd4c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey ! Can't wait to get this merged onto main branch to finally use it 🙏 |
matt-aitken
approved these changes
Jan 12, 2024
matt-aitken
left a comment
Member
There was a problem hiding this comment.
The code looks good 👍
This needs testing on:
- A regular Next.js project
- A Next.js project with HTTPS enabled
Member
|
Thanks a lot @Chigala, this is great 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #801
✅ Checklist
Testing
I started my NextJs server using the
--experimental https flagwith the nextjs project in the references folder and the used the-httpsflag on the CLI and it workded, then I also tested the CLI without the flag on the nextJs server not running https and it also worked.Changelog
NIL
Screenshots
💯

I'll love your feedbacks on this