fix(#785): type dump-manifests missing dir errors#3124
Open
Yeachan-Heo wants to merge 1 commit into
Open
Conversation
Automation needs dump-manifests argument failures to classify without scraping prose, so the --manifests-dir missing-value paths now share the missing_flag_value contract and usage hint. Constraint: Scope limited to ROADMAP #785 and existing rusty-claude-cli JSON error contracts. Rejected: Broader dump-manifests parser cleanup | outside the requested ROADMAP #785 packaging scope. Confidence: high Scope-risk: narrow Directive: Keep future dump-manifests argument errors typed and hint-bearing for JSON callers. Tested: cargo test -p rusty-claude-cli --test output_format_contract -- dump_manifests_missing_dir_has_typed_kind_and_hint_785 --nocapture; cargo test -p rusty-claude-cli classify_error_kind_returns_correct_discriminants -- --nocapture; cargo fmt --all -- --check Not-tested: full workspace test suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dump-manifests --manifests-dirmissing-value failures asmissing_flag_valuedump-manifestsusage hint for both separated and--manifests-dir=empty formsValidation
cargo test -p rusty-claude-cli --test output_format_contract -- dump_manifests_missing_dir_has_typed_kind_and_hint_785 --nocapturecargo test -p rusty-claude-cli classify_error_kind_returns_correct_discriminants -- --nocapturecargo fmt --all -- --check