Keep local pre-push gate output machine-clean#3125
Open
Yeachan-Heo wants to merge 1 commit into
Open
Conversation
The ROADMAP #694 local pre-push gate should catch stale Rust build breakage without polluting stdout that callers may reserve for structured output. Route the roadmap ID pre-check through stderr like the build gate messages. Constraint: ROADMAP #693-#695 verification already covers typed analog phase errors, the cargo build gate, and startup preflight warnings; this change only fixes the failing pre-push hook contract found during G013 validation. Rejected: Reworking hook installation or branch-protection policy | outside the local repository change surface available from this worktree. Confidence: high Scope-risk: narrow Directive: Keep pre-push status/progress output on stderr so stdout stays available for machine callers. Tested: python3 -m pytest tests/test_pre_push_hook_contract.py -q; cargo test --manifest-path rust/Cargo.toml -p claw-analog rag_response -- --nocapture; cargo test --manifest-path rust/Cargo.toml -p runtime startup_preflight -- --nocapture; python3 scripts/validate_cc2_board.py --board .omx/cc2/board.json; cargo fmt --manifest-path rust/Cargo.toml --all -- --check; cargo build --manifest-path rust/Cargo.toml --workspace --locked Not-tested: full cargo test --workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
python3 -m pytest tests/test_pre_push_hook_contract.py -qcargo test --manifest-path rust/Cargo.toml -p claw-analog rag_response -- --nocapturecargo test --manifest-path rust/Cargo.toml -p runtime startup_preflight -- --nocapturepython3 scripts/validate_cc2_board.py --board .omx/cc2/board.jsoncargo fmt --manifest-path rust/Cargo.toml --all -- --checkcargo build --manifest-path rust/Cargo.toml --workspace --lockedFinal gate
.github/hooks/pre-push: no-op/pass; explicit skip escape hatch is tested and non-masking