Skip to content

Merged: src: remove ArrayBufferAllocator::Reallocate override#190

Merged
syg merged 1 commit into
v8:node-ci-2024-06-03from
syg:node-ci-2024-06-03
Jun 21, 2024
Merged

Merged: src: remove ArrayBufferAllocator::Reallocate override#190
syg merged 1 commit into
v8:node-ci-2024-06-03from
syg:node-ci-2024-06-03

Conversation

@syg

@syg syg commented Jun 21, 2024

Copy link
Copy Markdown

It's being deprecated and removed in V8.

PR-URL: nodejs#52910
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@syg
syg requested review from ajklein and isheludko June 21, 2024 00:01

@ajklein ajklein left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@syg
syg merged commit cce9437 into v8:node-ci-2024-06-03 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants