fix: restore Windows cache links using target types - #159
Merged
Merged
Conversation
Contributor
✅ GitLab E2E passedCommit: |
fengmk2
force-pushed
the
codex/gitlab-cache-sfw-fixes
branch
from
September 15, 2026 07:26
ed77d6f to
f886117
Compare
fengmk2
added
run-e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Windows cache restore failure found in GitLab pipeline 2849366109.
Cache extraction can create a file link before its directory target exists. The runtime now checks the target path to select the correct link type. This avoids
EPERMwhen the extracted link cannot be followed.Add portable and Windows regression tests. Update
dist/gitlab/index.mjsto include the fix. Local tests pass; native Windows validation remains pending.GitLab test MR !3 addresses the two separate Linux assertion failures. Test both changes together before the full E2E run.