Skip to content

Verify SHASUMS.txt before installing Node #1807

Description

@sapphi-red

Description

Node signs the SHASUMS256.txt that contains the checksums of each binaries with a PGP signature. The way to verify is explained at https://github.com/nodejs/node#verifying-binaries.
But viteplus does not currently verify that.

This makes it difficult to attack Node.

Suggested solution

Download SHASUMS256.txt.asc instead and verify it here:

let shasums_content = download_text(url).await?;
Some(provider.parse_shasums(&shasums_content, &download_info.archive_filename)?)

Alternative

No response

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Confirm this request is for Vite+ itself and not for Vite, Vitest, tsdown, Rolldown, or Oxc.
  • Check that there isn't already an issue requesting the same feature.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Fields

Priority

None yet

Start date

None yet

Target date

None yet

Effort

None yet

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions