fix(pm): avoid implicit project writes by liangmiQwQ · Pull Request #2399 · voidzero-dev/vite-plus

liangmiQwQ · 2026-08-10T10:59:52Z

Close #2375
Close #2374
Close #1916

Package-manager commands resolve the manager and version from project metadata, then execute the managed binary for that exact version.

Package-manager detection is non-mutating. Lockfiles, config files, defaults, and devEngines.packageManager ranges are resolved for the current command without changing package.json. Projects can declare or remove a package-manager version explicitly with vp env pin and vp env unpin.

Project-local dependency commands such as vp install and vp add require an existing package.json. Managed global operations continue to use the Vite+ global package store.

🤖 Generated with Codex

netlify · 2026-08-10T10:59:57Z

✅ Deploy Preview for viteplus-preview ready!

Name	Link
🔨 Latest commit	`188ff9a`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a95f9c898cabc0008958f0c
😎 Deploy Preview	https://deploy-preview-2399--viteplus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

liangmiQwQ · 2026-08-31T03:42:37Z

@codex review

chatgpt-codex-connector · 2026-08-31T03:42:54Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-08-31T03:45:28.120203Z	`f70abe1`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-08-31T03:45:26Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: f70abe13c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ · 2026-08-31T13:55:06Z

@fengmk2 I'm ready for this.

fengmk2 · 2026-08-31T15:11:45Z

Need to fix ci fail before merge.

…ger-binary

@liangmiQwQ

`vp env` now manages Node.js and package-manager versions together. This release also fixes TanStack Start routing and stale Vitest aliases. ### Breaking Changes #### Package-manager setup Vite+ replaces Corepack with managed `npm`, `pnpm`, `yarn`, and `bun` commands. It removes the `corepack` shim and legacy global package-manager installations ([#2391](#2391)), by @liangmiQwQ. Replace Corepack setup commands in shell profiles, CI jobs, and Dockerfiles: | Previous setup | Replacement | | --- | --- | | `corepack enable` | `vp env setup` | | `vp install -g pnpm@<version>` | `vp env default pnpm@<version>` | | `vp install -g yarn@<version>` | `vp env default yarn@<version>` | | `vp install -g bun@<version>` | `vp env default bun@<version>` | | `vp install -g corepack` | Use the managed package-manager commands directly | Use `vp env pin <manager>@<version>` to set a project version. #### `vp env` command scope and JSON output Unscoped `vp env` commands now operate on Node.js and package managers. Package managers support independent defaults, project pins, session overrides, and installation commands ([#2398](#2398)), by @liangmiQwQ. Add `node` to limit an operation to Node.js, for example, `vp env off node` or `vp env unpin node`. Bare versions, such as `vp env default 22.19.0`, still select Node.js. Update scripts that read JSON output: | Command | New output structure | | --- | --- | | `vp env current --json` | `node` and `package_manager` objects | | `vp env list --json`, `vp env list-remote --json` | `node` and `package_managers` groups | See the [environment guide](https://viteplus.dev/guide/env). #### `vp pack` migration to `tsdown` `0.23` `vp pack` now uses `tsdown` `0.23`, which removes deprecated options and changes defaults ([#2614](#2614)), by @fengmk2. 1. Run `vp migrate` to update supported static configurations and package scripts, including projects that already use Vite+. 2. Check migration warnings in `vite.config.*`, `tsdown.config.*`, and `package.json`. 3. Update dynamic configurations manually. Arrays built with `.map()` require manual changes, even when migration reports no warning. 4. Run `vp pack` to check the result. | Previous option | Replacement | | --- | --- | | `bundle: false` | `unbundle: true` | | `outExtension` | `outExtensions` | | `publicDir` / `--public-dir` | `copy` / `--copy` | | `removeNodeProtocol: true` | `nodeProtocol: 'strip'` | | `injectStyle` | `css.inject` | | `inlineOnly` / `deps.onlyAllowBundle` | `deps.onlyBundle` | | `noExternal` | `deps.alwaysBundle` | | `skipNodeModulesBundle: true` / `deps.skipNodeModulesBundle: true` | `deps.neverBundle: true` | | `dts.tsgo: true` / `dts.oxc: true` | `dts.generator: 'tsgo'` / `dts.generator: 'oxc'` | Migration preserves the previous defaults for dependency resolution and ATTW. `tsdown` no longer supports Node.js `25`. Use Node.js `^22.18.0`, `^24.11.0`, or `>=26.0.0`. The programmatic `build()` API now returns `{ bundles, watch }`. See the [complete migration guide](https://github.com/rolldown/tsdown/releases/tag/v0.23.0) for declaration and TypeScript module-resolution changes. #### CLI argument validation `vp staged`, `vp config`, `vp hooks`, `vp migrate`, and `vp create` now reject unsupported options and extra positional arguments ([#2523](#2523)), by @fengmk2. Remove unsupported arguments from scripts. For example, replace `vp config --hooks-only` with `vp config --no-agent`. ### Highlights - Fix TanStack Start HTTP `404` responses caused by separate Vite runtime copies ([#2617](#2617)), by @fengmk2. - Reduce the Windows `vp-shim.exe` size from `214 KiB` to `14 KiB` ([#2466](#2466)), by @fengmk2. - Add `vp check --quiet` to hide lint warning diagnostics while retaining errors and summary counts ([#2593](#2593)), by @RSS1102. ### Features - Add `vp sync-versions --json` so automation can request dependency alignment plans from manifest snapshots without changing project files ([#2600](#2600)), by @afonsojramos. - Make `vp create --git` suggest an initial commit command after Git initialization ([#2581](#2581)), by @fengmk2. - Make `vp migrate` replace frozen `voidzero-dev/setup-vp@v1` workflow references with the supported version pin ([#2540](#2540)), by @fengmk2. - Upgrade `rolldown` from `1.2.5` to `1.2.7`, `tsdown` from `0.22.14` to `0.23.0`, and Oxc from `0.146.0` to `0.148.0`. Upgrade `oxlint` from `1.79.0` to `1.81.0` and `oxfmt` from `0.64.0` to `0.66.0`. These versions can flag code that passed before. Run `vp fmt` after upgrading if CI runs `vp check` ([#2580](#2580), [#2613](#2613)), by @voidzero-guard[bot]. ### Fixes & Enhancements - Resolve package-manager versions without rewriting `package.json`. Use `vp env pin` or `vp env unpin` to change project declarations explicitly ([#2399](#2399)), by @liangmiQwQ. - Let `vp migrate` repair stale `vitest` aliases that previously prevented the CLI from starting ([#2605](#2605)), by @fengmk2. - Keep Vite DevTools within the version ranges supported by the bundled Vite ([#2559](#2559)), by @fengmk2. - Keep automatic Vitest upgrades on the supported `4.x` major ([#2612](#2612)), by @fengmk2. - Remove a deprecated `tsdown` option from the prompts package build ([#2597](#2597)), by @jong-kyung. ### Refactor - Use the updated `which` dependency to resolve relative `PATH` entries ([#2583](#2583)), by @RSS1102. - Remove the unused `async-trait` annotation from `JsRuntimeProvider` ([#2538](#2538)), by @jong-kyung. ### Docs - Add Azure Pipelines setup instructions ([#2553](#2553)), by @naokihaba. - Correct Zed Oxc formatter settings and include JSX and TSX ([#2592](#2592)), by @joschuba. - Add Wrangler deployment configuration for the documentation site ([#2596](#2596)), by @mdong1909. - Explain conflicts between pnpm and Vite+ runtime management, including the `runtimeOnFail` setting ([#2620](#2620)), by @liangmiQwQ. ### Chore - Run CLI snapshots without published release packages ([#2625](#2625)), by @fengmk2. - Update the release-manager skill with package-install checks, changelog guidance, and announcement handling ([#2548](#2548)), by @fengmk2. - Wait for npm dependencies to become available before publishing dependent release packages ([#2601](#2601)), by @fengmk2. - Remove old Docker preview images ([#2539](#2539)), by @fengmk2. - Stabilize external-tool snapshots and isolate npm network cases ([#2577](#2577), [#2604](#2604)), by @fengmk2. - Avoid unreliable Fish PPA setup in CI ([#2560](#2560)), by @fengmk2. - Update the `vinext` fixture to an upstream fix ([#2571](#2571)), by @jong-kyung. - Stabilize the pnpm snapshot and Nuxt build in CI ([#2591](#2591)), by @voidzero-guard[bot]. - Pin pnpm in project-creation build-approval fixtures ([#2616](#2616)), by @liangmiQwQ. - Remove unused documentation components, assets, and the typewriter dependency ([#2550](#2550), [#2562](#2562)), by @jong-kyung. - Remove duplicate `tempfile` dependencies, an unused runtime helper, and unused error variants. Update the `unit_bindings` lint name ([#2555](#2555), [#2558](#2558), [#2566](#2566), [#2567](#2567)), by @jong-kyung. - Update GitHub Actions dependencies, including `actions/setup-node` `v7` ([#2544](#2544), [#2545](#2545), [#2582](#2582), [#2618](#2618)), by @renovate[bot]. - Update `crate-ci/typos` through `v1.50.1` ([#2584](#2584), [#2589](#2589), [#2609](#2609)), by @renovate[bot]. - Update repository pnpm to `11.24.0` ([#2590](#2590)), by @renovate[bot]. - Update `voidzero-dev/setup-vp` to `v1.19.0` ([#2619](#2619)), by @renovate[bot]. ### Bundled Versions | Tool | Version | Source | | --- | --- | --- | | `vite` | `8.2.2` | [`de1111a`](vitejs/vite@de1111a) | | `rolldown` | `1.2.7` | [`26b4c6e`](rolldown/rolldown@26b4c6e) | | `tsdown` | `0.23.0` | [npm](https://npmx.dev/package/tsdown/v/0.23.0) | | `vitest` | `4.1.11` | [npm](https://npmx.dev/package/vitest/v/4.1.11) | | `oxlint` | `1.81.0` | [npm](https://npmx.dev/package/oxlint/v/1.81.0) | | `oxlint-tsgolint` | `7.0.2001` | [npm](https://npmx.dev/package/oxlint-tsgolint/v/7.0.2001) | | `oxfmt` | `0.66.0` | [npm](https://npmx.dev/package/oxfmt/v/0.66.0) | ### Upgrade ```bash vp upgrade ``` ### New Contributors @afonsojramos, @joschuba **Full Changelog**: v0.3.0...v0.3.1 --- Merging this PR will trigger the release workflow. --------- Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com> Co-authored-by: MK (fengmk2) <fengmk2@gmail.com>

liangmiQwQ force-pushed the refactor-breaking/directly-call-package-manager-binary branch 18 times, most recently from c2d45b6 to 22afb4f Compare August 12, 2026 03:36

liangmiQwQ changed the title ~~refactor(pm): execute package managers from PATH~~ refactor(pm)!: dispatch package managers from PATH without probing Aug 12, 2026

liangmiQwQ force-pushed the refactor-breaking/directly-call-package-manager-binary branch 5 times, most recently from d00de4b to c7a0290 Compare August 12, 2026 13:15

This was referenced Aug 12, 2026

feat(env)!: replace Corepack with package manager shims #2391

Merged

feat(env)!: manage package manager environments #2398

Merged

liangmiQwQ marked this pull request as ready for review August 12, 2026 13:16

liangmiQwQ marked this pull request as draft August 12, 2026 13:18

liangmiQwQ changed the title ~~refactor(pm)!: dispatch package managers from PATH without probing~~ refactor(pm)!: dispatch package managers from PATH Aug 12, 2026

fengmk2 self-assigned this Aug 30, 2026

liangmiQwQ added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Aug 30, 2026

liangmiQwQ added 7 commits August 31, 2026 11:18

fix(pm): avoid implicit project writes

f3c00ff

refactor(pm): avoid redundant project lookup

669b1df

style(rfc): format project mutation matrix

91ed326

fix(cli): preserve workspace-not-found errors

1e17bae

fix(pm): align refreshed manager dispatch

c618a93

refactor(pm): simplify manager dispatch

dde1250

fix(pm): validate project before manager resolution

f70abe1

liangmiQwQ force-pushed the refactor-breaking/directly-call-package-manager-binary branch from 642eeb0 to f70abe1 Compare August 31, 2026 03:20

fengmk2 reviewed Aug 31, 2026

View reviewed changes

Comment thread docs/guide/install.md Outdated

fengmk2 reviewed Aug 31, 2026

View reviewed changes

Comment thread ..._snapshots/fixtures/command_pm_no_package_json/snapshots/command_pm_no_package_json.local.md Outdated

wip

c384bcf

liangmiQwQ requested a review from fengmk2 August 31, 2026 14:42

fengmk2 approved these changes Aug 31, 2026

View reviewed changes

liangmiQwQ added 2 commits September 1, 2026 06:01

test(cli): remove obsolete manifest snapshot

87a627d

Merge branch 'main' into refactor-breaking/directly-call-package-mana…

188ff9a

…ger-binary

liangmiQwQ requested a review from fengmk2 August 31, 2026 22:24

fengmk2 merged commit d4dad55 into voidzero-dev:main Sep 1, 2026
128 checks passed

liangmiQwQ deleted the refactor-breaking/directly-call-package-manager-binary branch September 1, 2026 13:11

fengmk2 mentioned this pull request Sep 7, 2026

release: v0.3.1: manage package-manager versions with vp env #2623

Merged

Navigation Menu

Uh oh!

fix(pm): avoid implicit project writes - #2399

fix(pm): avoid implicit project writes#2399
fengmk2 merged 10 commits into
voidzero-dev:mainfrom
liangmiQwQ:refactor-breaking/directly-call-package-manager-binary

liangmiQwQ commented Aug 10, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Aug 10, 2026 •

edited

Loading

Uh oh!

liangmiQwQ commented Aug 31, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 31, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Aug 31, 2026

Uh oh!

liangmiQwQ commented Aug 31, 2026

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Aug 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

liangmiQwQ commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview ready!

Uh oh!

liangmiQwQ commented Aug 31, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot commented Aug 31, 2026

Uh oh!

liangmiQwQ commented Aug 31, 2026

Uh oh!

Uh oh!

Uh oh!

fengmk2 commented Aug 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

liangmiQwQ commented Aug 10, 2026 •

edited

Loading

netlify Bot commented Aug 10, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Aug 31, 2026 •

edited

Loading