chore(core): remove unused Babel dependencies - #2634
Merged
fengmk2 merged 3 commits intoSep 10, 2026
Conversation
rolldown-plugin-dts now uses yuku-parser and yuku-codegen, so core no longer needs direct Babel dependencies. Keep upstream Vite's own parser dependency intact.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fengmk2
approved these changes
Sep 9, 2026
fengmk2
added
test: e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core no longer needs direct dependencies on
@babel/generator,@babel/parser, or@babel/typesbecause the currentrolldown-plugin-dtsusesyuku-parserandyuku-codegeninstead.These packages originally covered runtime requirements from
rolldown-plugin-dtsbundled into tsdown. They later moved todevDependencieswhenbuild-cjs-deps.tsbegan bundling those CJS dependencies into core's output.This removes the leftover declarations without changing CJS bundling. Upstream Vite retains its own
@babel/parserdependency, and other consumers retain their transitive Babel dependencies.Related: #396